[net/auth] Don't abort network transaction over non-permanent auth errors.

net/http/http_auth_controller_unittest.cc

Index: net/http/http_auth_controller_unittest.cc
diff --git a/net/http/http_auth_controller_unittest.cc b/net/http/http_auth_controller_unittest.cc
index fb42ebf5fa495120ae089da25b53010e1015a19c..ea2f12a17c51ea14ca11f4e04de388712fbbbf0e 100644
--- a/net/http/http_auth_controller_unittest.cc
+++ b/net/http/http_auth_controller_unittest.cc
@@ -114,8 +114,15 @@ TEST(HttpAuthControllerTest, PermanentErrors) {
 
   // If a non-permanent error is returned by the handler, then the
   // controller should report it unchanged.
-  RunSingleRoundAuthTest(RUN_HANDLER_ASYNC, ERR_INVALID_AUTH_CREDENTIALS,
-                         ERR_INVALID_AUTH_CREDENTIALS, SCHEME_IS_ENABLED);
+  RunSingleRoundAuthTest(RUN_HANDLER_ASYNC, ERR_UNEXPECTED, ERR_UNEXPECTED,
+                         SCHEME_IS_ENABLED);
+
+  // ERR_INVALID_AUTH_CREDENTIALS is special. It's a non-permanet error, but

[mmenke, 2016/10/04 19:42:15]

Should we update the description of this in net_error_list.h?  It's not obvious
that this is a local error, not the server rejecting our credentials...Or can it
be caused by both?

[asanka, 2016/10/06 14:16:35]

It could be caused by both. In this specific bug, the credentials were rejected
by the client (e.g. the server's challenge didn't have some property that's
required by client policy). But it could be rejected by the server as well (e.g.
the client didn't support some feature of the auth mechanism required by
policy).

+  // the error isn't propagated, nor is the auth scheme disabled. This allows
+  // the scheme to re-attempt the authentication attempt using a different set
+  // of credentials.
+  RunSingleRoundAuthTest(RUN_HANDLER_ASYNC, ERR_INVALID_AUTH_CREDENTIALS, OK,
+                         SCHEME_IS_ENABLED);
 }
 
 // If an HttpAuthHandler indicates that it doesn't allow explicit