MD Settings: drop subpage arrow from default browser section

MD Settings: drop subpage arrow from default browser section

Instead, show a "MAKE DEFAULT" button as a call to action so it's clearer
how a user can change their default browser.

R=dschuyler@chromium.org
BUG=651720
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c59443f0412c8dd63a59f0e2ce556bfd7151e1d0
Cr-Commit-Position: refs/heads/master@{#422896}

[Dan Beam, 2016-09-30 21:03:27]

Description was changed from

==========
MD Settings: drop subpage arrow from default browser section

R=dschuyler@chromium.org
BUG=651720
==========

to

==========
MD Settings: drop subpage arrow from default browser section

R=dschuyler@chromium.org
BUG=651720
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-09-30 21:04:07]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 21:04:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 22:39:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 22:39:53]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-10-03 21:00:10]

On 2016/09/30 21:04:03, Dan Beam wrote:

I'm guessing this CL will update to follow the changes in the bug
https://bugs.chromium.org/p/chromium/issues/detail?id=651720

Please let me know if you'd like to land patch#1 separately from 
adding the Make Default button.

[Dan Beam, 2016-10-04 18:31:00]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 18:31:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-10-04 18:41:56]

https://codereview.chromium.org/2382243003/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/default_browser_page/default_browser_page.html
(right):

https://codereview.chromium.org/2382243003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/default_browser_page/default_browser_page.html:22:
<paper-button on-tap="onSetDefaultBrowserTap_">
Should this paper-button have class="secondary-button"?

[Dan Beam, 2016-10-04 18:46:56]

screenshot with secondary-button applied:
http://i.imgur.com/fkaJRyX.png

note: yes, i am hacking the UI into showing on chromium

https://codereview.chromium.org/2382243003/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/default_browser_page/default_browser_page.html
(right):

https://codereview.chromium.org/2382243003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/default_browser_page/default_browser_page.html:22:
<paper-button on-tap="onSetDefaultBrowserTap_">
On 2016/10/04 18:41:56, dschuyler wrote:
> Should this paper-button have class="secondary-button"?

Done. (sorry, missed the weight difference and i'm colorblind so i didn't notice
gray vs black)

thanks for catching!

[dschuyler, 2016-10-04 18:48:49]

lgtm

[Dan Beam, 2016-10-04 18:50:13]

Description was changed from

==========
MD Settings: drop subpage arrow from default browser section

R=dschuyler@chromium.org
BUG=651720
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: drop subpage arrow from default browser section

Instead, show a "MAKE DEFAULT" button as a call to action so it's clearer
how a user can change their default browser.

R=dschuyler@chromium.org
BUG=651720
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-10-04 18:50:42]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-10-04 18:51:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 20:10:02]

Description was changed from

==========
MD Settings: drop subpage arrow from default browser section

Instead, show a "MAKE DEFAULT" button as a call to action so it's clearer
how a user can change their default browser.

R=dschuyler@chromium.org
BUG=651720
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: drop subpage arrow from default browser section

Instead, show a "MAKE DEFAULT" button as a call to action so it's clearer
how a user can change their default browser.

R=dschuyler@chromium.org
BUG=651720
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-04 20:10:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-04 20:14:50]

Description was changed from

==========
MD Settings: drop subpage arrow from default browser section

Instead, show a "MAKE DEFAULT" button as a call to action so it's clearer
how a user can change their default browser.

R=dschuyler@chromium.org
BUG=651720
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: drop subpage arrow from default browser section

Instead, show a "MAKE DEFAULT" button as a call to action so it's clearer
how a user can change their default browser.

R=dschuyler@chromium.org
BUG=651720
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c59443f0412c8dd63a59f0e2ce556bfd7151e1d0
Cr-Commit-Position: refs/heads/master@{#422896}
==========

[commit-bot: I haz the power, 2016-10-04 20:14:51]

Patchset 3 (id:??) landed as
https://crrev.com/c59443f0412c8dd63a59f0e2ce556bfd7151e1d0
Cr-Commit-Position: refs/heads/master@{#422896}