third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click-outside.html - Issue 2382233002: Hide overflow menu/closed caption list when clicking outside the list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click-outside.html

Issue 2382233002: Hide overflow menu/closed caption list when clicking outside the list (Closed)

Patch Set: applied Mounir's comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-closed-captions-list-hide-on-click-outside.html ('k') | third_party/WebKit/Source/core/html/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click-outside.html

diff --git a/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click.html b/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click-outside.html

similarity index 91%

copy from third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click.html

copy to third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click-outside.html

index a1e7dd610ea6d4201ef281a54e272af7643cd810..24d5cbb7c67460f46c9f3e79aab6bb4133e7b204 100644

--- a/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click.html

+++ b/third_party/WebKit/LayoutTests/media/video-controls-overflow-menu-hide-on-click-outside.html

@@ -29,8 +29,8 @@ async_test(function(t) {

clickAtCoordinates(coords[0], coords[1]);

assert_not_equals(getComputedStyle(overflowList).display, "none");

- // Click on an overflow menu item should close overflow list.

- var coords = elementCoordinates(overflowList);

+ // Click anywhere outside the overflow menu should close overflow list.

+ var coords = coordinatesOutsideElement(overflowList);

clickAtCoordinates(coords[0], coords[1]);

assert_equals(getComputedStyle(overflowList).display, "none");

});