Have EditCommand classes deal with Document references, not pointers

Source/core/editing/SplitTextNodeCommand.cpp

 /*
  * Copyright (C) 2005, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 18 matching lines @@
 #include "bindings/v8/ExceptionState.h"
 #include "bindings/v8/ExceptionStatePlaceholder.h"
 #include "core/dom/Document.h"
 #include "core/dom/DocumentMarkerController.h"
 #include "core/dom/Text.h"
 #include "wtf/Assertions.h"
 
 namespace WebCore {
 
 SplitTextNodeCommand::SplitTextNodeCommand(PassRefPtr<Text> text, int offset)
-    : SimpleEditCommand(&text->document())
+    : SimpleEditCommand(text->document())
     , m_text2(text)
     , m_offset(offset)
 {
     // NOTE: Various callers rely on the fact that the original node becomes
     // the second node (i.e. the new node is inserted before the existing one).
     // That is not a fundamental dependency (i.e. it could be re-coded), but
     // rather is based on how this code happens to work.
     ASSERT(m_text2);
     ASSERT(m_text2->length() > 0);
     ASSERT(m_offset > 0);
     ASSERT(m_offset < m_text2->length());
 }
 
 void SplitTextNodeCommand::doApply()
 {
     ContainerNode* parent = m_text2->parentNode();
     if (!parent || !parent->rendererIsEditable())
         return;
 
     String prefixText = m_text2->substringData(0, m_offset, IGNORE_EXCEPTION);
     if (prefixText.isEmpty())
         return;
 
-    m_text1 = Text::create(document(), prefixText);
+    m_text1 = Text::create(&document(), prefixText);
     ASSERT(m_text1);
-    document()->markers()->copyMarkers(m_text2.get(), 0, m_offset, m_text1.get(), 0);
+    document().markers()->copyMarkers(m_text2.get(), 0, m_offset, m_text1.get(), 0);
 
     insertText1AndTrimText2();
 }
 
 void SplitTextNodeCommand::doUnapply()
 {
     if (!m_text1 || !m_text1->rendererIsEditable())
         return;
 
-    ASSERT(&m_text1->document() == document());
+    ASSERT(&m_text1->document() == &document());
 
     String prefixText = m_text1->data();
 
     m_text2->insertData(0, prefixText, ASSERT_NO_EXCEPTION, DeprecatedAttachNow);
 
-    document()->markers()->copyMarkers(m_text1.get(), 0, prefixText.length(), m_text2.get(), 0);
+    document().markers()->copyMarkers(m_text1.get(), 0, prefixText.length(), m_text2.get(), 0);
     m_text1->remove(ASSERT_NO_EXCEPTION);
 }
 
 void SplitTextNodeCommand::doReapply()
 {
     if (!m_text1 || !m_text2)
         return;
 
     ContainerNode* parent = m_text2->parentNode();
     if (!parent || !parent->rendererIsEditable())
@@ skipping 13 matching lines @@
 
 #ifndef NDEBUG
 void SplitTextNodeCommand::getNodesInCommand(HashSet<Node*>& nodes)
 {
     addNodeAndDescendants(m_text1.get(), nodes);
     addNodeAndDescendants(m_text2.get(), nodes);
 }
 #endif
 
 } // namespace WebCore