Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 23822002: Adding new mock classes for input method handlers (Closed)

Created:
7 years, 3 months ago by Seigo Nonaka
Modified:
7 years, 3 months ago
Reviewers:
satorux1, Hiro Komatsu
CC:
chromium-reviews, nona+watch_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Adding new mock classes for input method handlers. We need to migrate current tests to ibus independent implementation. Following tests currently depends to ibus modules. - ui/base/ime/input_method_ibus_unittests.cc - chrome/browser/chromeos/input_method/input_method_engein_ibus_browsertest.cc (to be renamed to input_method_engine_browsertest.cc) BUG=275262 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221004

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+549 lines, -0 lines) Patch
M chromeos/chromeos.gyp View 1 chunk +8 lines, -0 lines 0 comments Download
A chromeos/ime/mock_ime_candidate_window_handler.h View 1 chunk +75 lines, -0 lines 0 comments Download
A chromeos/ime/mock_ime_candidate_window_handler.cc View 1 1 chunk +60 lines, -0 lines 0 comments Download
A chromeos/ime/mock_ime_engine_handler.h View 1 chunk +90 lines, -0 lines 0 comments Download
A chromeos/ime/mock_ime_engine_handler.cc View 1 1 chunk +84 lines, -0 lines 0 comments Download
A chromeos/ime/mock_ime_input_context_handler.h View 1 chunk +90 lines, -0 lines 0 comments Download
A chromeos/ime/mock_ime_input_context_handler.cc View 1 chunk +68 lines, -0 lines 0 comments Download
A chromeos/ime/mock_ime_property_handler.h View 1 1 chunk +40 lines, -0 lines 0 comments Download
A chromeos/ime/mock_ime_property_handler.cc View 1 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Seigo Nonaka
Hi Satrou, could you take a look?
7 years, 3 months ago (2013-08-30 13:42:42 UTC) #1
satorux1
Please update the patch description and describe why these new mocks are needed. https://codereview.chromium.org/23822002/diff/6001/chromeos/ime/mock_ime_candidate_window_handler.cc File ...
7 years, 3 months ago (2013-09-02 01:45:40 UTC) #2
Seigo Nonaka
https://codereview.chromium.org/23822002/diff/6001/chromeos/ime/mock_ime_candidate_window_handler.cc File chromeos/ime/mock_ime_candidate_window_handler.cc (right): https://codereview.chromium.org/23822002/diff/6001/chromeos/ime/mock_ime_candidate_window_handler.cc#newcode51 chromeos/ime/mock_ime_candidate_window_handler.cc:51: set_cursor_location_call_count_++; On 2013/09/02 01:45:40, satorux1 wrote: > nit: ++set_cursor_location_call_count_; ...
7 years, 3 months ago (2013-09-02 03:03:10 UTC) #3
satorux1
lgtm
7 years, 3 months ago (2013-09-03 06:20:38 UTC) #4
satorux1
lgtm
7 years, 3 months ago (2013-09-03 06:20:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/23822002/12001
7 years, 3 months ago (2013-09-03 09:58:04 UTC) #6
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=74906
7 years, 3 months ago (2013-09-03 18:43:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/23822002/12001
7 years, 3 months ago (2013-09-03 18:44:55 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-03 20:02:00 UTC) #9
Message was sent while issue was closed.
Change committed as 221004

Powered by Google App Engine
This is Rietveld 408576698