Purge image frame after checking for sufficient data.

Purge image frame after checking for sufficient data.

It is possible to only have some of the image downloaded and attempt to
display an animation frame at the end. When this happens, we would purge
important frames.

BUG=652046
Committed: https://crrev.com/f83ed479d26f231eaa40ac68458e98e42127b383
Cr-Commit-Position: refs/heads/master@{#422605}

[cblume, 2016-10-01 11:01:15]

The CQ bit was checked by cblume@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-01 11:01:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cblume, 2016-10-01 11:07:13]

cblume@chromium.org changed reviewers:
+ pkasting@google.com, scroggo@google.com, urvang@chromium.org

[cblume, 2016-10-01 11:07:13]

PTAL

[commit-bot: I haz the power, 2016-10-01 12:17:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 12:17:44]

Dry run: Exceeded global retry quota

[urvang, 2016-10-03 19:19:05]

lgtm

[cblume, 2016-10-03 19:36:56]

The CQ bit was checked by cblume@chromium.org

[commit-bot: I haz the power, 2016-10-03 19:37:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 21:03:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 21:03:45]

Failed to apply patch for
third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:
While running git apply --index -3 -p1;
  error: patch failed:
third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:317
  Falling back to three-way merge...
  Applied patch to
'third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp' with
conflicts.
  U third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp

Patch:      
third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp
Index: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp
diff --git
a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp
b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp
index
ba4cca2bb13c8da2bcc7cbc66cdad6fd869999b3..3515288772e128af27e57b72d4e467b4444b6dcd
100644
--- a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp
+++ b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp
@@ -317,12 +317,12 @@ void GIFImageDecoder::decode(size_t index)
             return;
         }
 
-        if (m_purgeAggressively)
-            clearCacheExceptFrame(*i);
-
         // We need more data to continue decoding.
         if (m_frameBufferCache[*i].getStatus() != ImageFrame::FrameComplete)
             break;
+
+        if (m_purgeAggressively)
+            clearCacheExceptFrame(*i);
     }
 
     // It is also a fatal error if all data is received and we have decoded all

[cblume, 2016-10-03 22:16:53]

The CQ bit was checked by cblume@chromium.org

[cblume, 2016-10-03 22:16:54]

The patchset sent to the CQ was uploaded after l-g-t-m from urvang@chromium.org
Link to the patchset: https://codereview.chromium.org/2382143004/#ps20001
(title: "Rebasing.")

[commit-bot: I haz the power, 2016-10-03 22:17:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 23:53:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-03 23:55:38]

Description was changed from

==========
Purge image frame after checking for sufficient data.

It is possible to only have some of the image downloaded and attempt to
display an animation frame at the end. When this happens, we would purge
important frames.

BUG=652046
==========

to

==========
Purge image frame after checking for sufficient data.

It is possible to only have some of the image downloaded and attempt to
display an animation frame at the end. When this happens, we would purge
important frames.

BUG=652046

Committed: https://crrev.com/f83ed479d26f231eaa40ac68458e98e42127b383
Cr-Commit-Position: refs/heads/master@{#422605}
==========

[commit-bot: I haz the power, 2016-10-03 23:55:39]

Patchset 2 (id:??) landed as
https://crrev.com/f83ed479d26f231eaa40ac68458e98e42127b383
Cr-Commit-Position: refs/heads/master@{#422605}