Abort git tools if git repo has too many local branches.

Abort git tools if git repo has too many local branches.

This is a stopgap to prevent people with >20 local branches from running tools
like 'git rebase-update'. This usually indicates that the user isn't in the
habit of cleaning up old branches, which makes these tools unlikely to be useful
in the current state of their repo anyway.

R=agable@chromium.org
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=263978

[iannucci, 2014-04-15 01:14:50]

On 2014/04/15 00:33:08, iannucci wrote:

+stip, +scottmg

This one's for you guys :P

[ghost stip (do not use), 2014-04-15 18:19:18]

lgtm % changes

https://chromiumcodereview.appspot.com/238213006/diff/1/git_common.py
File git_common.py (right):

https://chromiumcodereview.appspot.com/238213006/diff/1/git_common.py#newcode243
git_common.py:243: 
Seems like you'd want to split this check out to a separate function, right? Is
there a way to make it optional for tools where this limit doesn't apply?

https://chromiumcodereview.appspot.com/238213006/diff/1/git_common.py#newcode258
git_common.py:258: You may adjust this limit with the config variable %s
It would be polite to print the git command to do this

[iannucci, 2014-04-15 20:00:34]

On 2014/04/15 18:19:18, stip wrote:
> lgtm % changes
> 
> https://chromiumcodereview.appspot.com/238213006/diff/1/git_common.py
> File git_common.py (right):
> 
>
https://chromiumcodereview.appspot.com/238213006/diff/1/git_common.py#newcode243
> git_common.py:243: 
> Seems like you'd want to split this check out to a separate function, right?
Is
> there a way to make it optional for tools where this limit doesn't apply?

It only applies to tools which loop over branches() (which is why I added it to
the branches() function).

In general, we need to go on a optimization rampage for these tools. They shell
out too much and I suspect that some caching would really improve the situation.

> 
>
https://chromiumcodereview.appspot.com/238213006/diff/1/git_common.py#newcode258
> git_common.py:258: You may adjust this limit with the config variable %s
> It would be polite to print the git command to do this

Done

[iannucci, 2014-04-15 20:00:52]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2014-04-15 20:01:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iannucci@chromium.org/238213006/20001

[commit-bot: I haz the power, 2014-04-15 20:02:45]

Change committed as 263978