Use scrollbar thickness to set layout

Use scrollbar thickness to set layout

BUG=651940
COMPONENT=Paint, ScrollableArea, Scrollbar
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/8d329a8b3ca5f11c064d1e109404613758dc3b45
Cr-Commit-Position: refs/heads/master@{#422706}

[malaykeshav, 2016-10-02 00:56:34]

Description was changed from

==========
Use scrollbar thickness to set layout

BUG=651940
COMPONENT=Paint, ScrollableArea, Scrollbar
==========

to

==========
Use scrollbar thickness to set layout

BUG=651940
COMPONENT=Paint, ScrollableArea, Scrollbar
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[malaykeshav, 2016-10-02 00:57:24]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-02 00:57:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-02 02:44:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-02 02:44:57]

Dry run: This issue passed the CQ dry run.

[malaykeshav, 2016-10-03 16:53:10]

malaykeshav@chromium.org changed reviewers:
+ oshima@chromium.org, wangxianzhu@chromium.org

[malaykeshav, 2016-10-03 16:53:11]

PTAL

[Xianzhu, 2016-10-03 17:03:49]

The change looks good. Can you add a test?

[malaykeshav, 2016-10-03 17:22:47]

On 2016/10/03 at 17:03:49, wangxianzhu wrote:
> The change looks good. Can you add a test?

Doesn't the scrollbar width/thickness test during DPI change check for this
already?

[Xianzhu, 2016-10-03 17:37:57]

On 2016/10/03 at 17:22:47, malaykeshav wrote:
> On 2016/10/03 at 17:03:49, wangxianzhu wrote:
> > The change looks good. Can you add a test?
> 
> Doesn't the scrollbar width/thickness test during DPI change check for this
already?

Does this CL change the behavior of the tests? If not, the tests seem not to
test this CL.

[malaykeshav, 2016-10-03 17:39:29]

On 2016/10/03 at 17:37:57, wangxianzhu wrote:
> On 2016/10/03 at 17:22:47, malaykeshav wrote:
> > On 2016/10/03 at 17:03:49, wangxianzhu wrote:
> > > The change looks good. Can you add a test?
> > 
> > Doesn't the scrollbar width/thickness test during DPI change check for this
already?
> 
> Does this CL change the behavior of the tests? If not, the tests seem not to
test this CL.

This CL changes the behavior of the test:
https://storage.googleapis.com/chromium-layout-test-archives/linux_precise_bl...

[Xianzhu, 2016-10-03 18:35:58]

On 2016/10/03 17:39:29, malaykeshav wrote:
> On 2016/10/03 at 17:37:57, wangxianzhu wrote:
> > On 2016/10/03 at 17:22:47, malaykeshav wrote:
> > > On 2016/10/03 at 17:03:49, wangxianzhu wrote:
> > > > The change looks good. Can you add a test?
> > > 
> > > Doesn't the scrollbar width/thickness test during DPI change check for
this
> already?
> > 
> > Does this CL change the behavior of the tests? If not, the tests seem not to
> test this CL.
> 
> This CL changes the behavior of the test:
>
https://storage.googleapis.com/chromium-layout-test-archives/linux_precise_bl...

lgtm.

Please remove the failure entry from TestExpectations and rebaseline it. (All
green try bot results made me think the CL changed nothing.)

[malaykeshav, 2016-10-03 18:39:21]

The CQ bit was checked by malaykeshav@chromium.org

[commit-bot: I haz the power, 2016-10-03 18:39:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2016-10-03 18:40:01]

On 2016/10/03 at 18:35:58, wangxianzhu wrote:
> On 2016/10/03 17:39:29, malaykeshav wrote:
> > On 2016/10/03 at 17:37:57, wangxianzhu wrote:
> > > On 2016/10/03 at 17:22:47, malaykeshav wrote:
> > > > On 2016/10/03 at 17:03:49, wangxianzhu wrote:
> > > > > The change looks good. Can you add a test?
> > > > 
> > > > Doesn't the scrollbar width/thickness test during DPI change check for
this
> > already?
> > > 
> > > Does this CL change the behavior of the tests? If not, the tests seem not
to
> > test this CL.
> > 
> > This CL changes the behavior of the test:
> >
https://storage.googleapis.com/chromium-layout-test-archives/linux_precise_bl...
> 
> lgtm.
> 
> Please remove the failure entry from TestExpectations and rebaseline it. (All
green try bot results made me think the CL changed nothing.)

Its already at [ NeedsRebaeline ]

[Xianzhu, 2016-10-03 18:41:27]

The CQ bit was unchecked by wangxianzhu@chromium.org

[malaykeshav, 2016-10-03 18:43:13]

On 2016/10/03 at 18:40:01, malaykeshav wrote:
> On 2016/10/03 at 18:35:58, wangxianzhu wrote:
> > On 2016/10/03 17:39:29, malaykeshav wrote:
> > > On 2016/10/03 at 17:37:57, wangxianzhu wrote:
> > > > On 2016/10/03 at 17:22:47, malaykeshav wrote:
> > > > > On 2016/10/03 at 17:03:49, wangxianzhu wrote:
> > > > > > The change looks good. Can you add a test?
> > > > > 
> > > > > Doesn't the scrollbar width/thickness test during DPI change check for
this
> > > already?
> > > > 
> > > > Does this CL change the behavior of the tests? If not, the tests seem
not to
> > > test this CL.
> > > 
> > > This CL changes the behavior of the test:
> > >
https://storage.googleapis.com/chromium-layout-test-archives/linux_precise_bl...
> > 
> > lgtm.
> > 
> > Please remove the failure entry from TestExpectations and rebaseline it.
(All green try bot results made me think the CL changed nothing.)
> 
> Its already at [ NeedsRebaeline ]

https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/TestExpec...

[Xianzhu, 2016-10-03 18:44:44]

On 2016/10/03 18:40:01, malaykeshav wrote:
> On 2016/10/03 at 18:35:58, wangxianzhu wrote:
> > On 2016/10/03 17:39:29, malaykeshav wrote:
> > > On 2016/10/03 at 17:37:57, wangxianzhu wrote:
> > > > On 2016/10/03 at 17:22:47, malaykeshav wrote:
> > > > > On 2016/10/03 at 17:03:49, wangxianzhu wrote:
> > > > > > The change looks good. Can you add a test?
> > > > > 
> > > > > Doesn't the scrollbar width/thickness test during DPI change check for
> this
> > > already?
> > > > 
> > > > Does this CL change the behavior of the tests? If not, the tests seem
not
> to
> > > test this CL.
> > > 
> > > This CL changes the behavior of the test:
> > >
>
https://storage.googleapis.com/chromium-layout-test-archives/linux_precise_bl...
> > 
> > lgtm.
> > 
> > Please remove the failure entry from TestExpectations and rebaseline it.
(All
> green try bot results made me think the CL changed nothing.)
> 
> Its already at [ NeedsRebaeline ]

Is it from the previous CL? This will confuse the rebaseline-bot. It examines in
which CL the NeedsRebaseline was added, and will rebaseline the test to the
status of that CL. You should wait for the auto-rebaseline finish for that CL
and add NeedsRebaseline in this CL to let the rebaseline-bot rebaseline the test
to the status of this CL.

[malaykeshav, 2016-10-03 23:56:52]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 23:57:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 01:38:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 01:38:04]

Dry run: This issue passed the CQ dry run.

[malaykeshav, 2016-10-04 04:25:14]

The CQ bit was checked by malaykeshav@chromium.org

[malaykeshav, 2016-10-04 04:25:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2382103006/#ps20001
(title: "Updated Layout Test Expectations")

[commit-bot: I haz the power, 2016-10-04 04:25:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 04:32:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-04 04:35:02]

Description was changed from

==========
Use scrollbar thickness to set layout

BUG=651940
COMPONENT=Paint, ScrollableArea, Scrollbar
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Use scrollbar thickness to set layout

BUG=651940
COMPONENT=Paint, ScrollableArea, Scrollbar
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/8d329a8b3ca5f11c064d1e109404613758dc3b45
Cr-Commit-Position: refs/heads/master@{#422706}
==========

[commit-bot: I haz the power, 2016-10-04 04:35:03]

Patchset 2 (id:??) landed as
https://crrev.com/8d329a8b3ca5f11c064d1e109404613758dc3b45
Cr-Commit-Position: refs/heads/master@{#422706}