Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2382093002: Merge M54: "Fix initial buffer sizes and improve partial underflow support." (Closed)

Created:
4 years, 2 months ago by DaleCurtis
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Merge M54: "Fix initial buffer sizes and improve partial underflow support." On devices with massive buffer sizes, src= playback will often use a size too small to satisfy the OS request. So we end up only filling most of it, but end up with enough data such that the next call does not cause an underflow. The fixes are two fold: 1. Use a better initial size when possible. 2. Increase queue capacity anytime we have a partial fill. BUG=650601 TEST=new unittests. --audio-buffer-size=11160 doesn't glitch. Review-Url: https://codereview.chromium.org/2375713003 Cr-Commit-Position: refs/heads/master@{#421691} (cherry picked from commit 95d0b149bbb2ec028a24d833ddb5351912f40a93) Committed: https://chromium.googlesource.com/chromium/src/+/e8271e28d949967b994dc99f608e742f64c8b33b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -8 lines) Patch
M media/renderers/audio_renderer_impl.cc View 2 chunks +15 lines, -8 lines 0 comments Download
M media/renderers/audio_renderer_impl_unittest.cc View 2 chunks +46 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
4 years, 2 months ago (2016-09-29 23:02:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e8271e28d949967b994dc99f608e742f64c8b33b.

Powered by Google App Engine
This is Rietveld 408576698