Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2382083002: Make LayoutTests ambivalent of of anonymous blocks (Closed)

Created:
4 years, 2 months ago by dmazzoni
Modified:
4 years, 2 months ago
Reviewers:
aboxhall
CC:
chromium-reviews, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, nektarios, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, blink-reviews, dmazzoni
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make LayoutTests ambivalent of of anonymous blocks This change only improves some tests, no code is changed. Basically I modified computeAccessibilityIsIgnored and had it ignore all anonymous blocks, then fixed all tests that broke so they'd pass with or without the change, then reverted the code change. That way a future change that simplifies computeAccessibilityIsIgnored won't break any LayoutTests, making it smaller and easier to review. BUG=651614 Committed: https://crrev.com/025c55dda400a5d2dd2ec435da38ec0d70a0d348 Cr-Commit-Position: refs/heads/master@{#422235}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -59 lines) Patch
M third_party/WebKit/LayoutTests/accessibility/aria-disabled.html View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-label.html View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-used-on-image-maps.html View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/ignore-spacer-elements.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/img-aria-button-alt-tag.html View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/img-fallsback-to-title.html View 2 chunks +10 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/img-fallsback-to-title-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/legend.html View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/nochildren-elements.html View 2 chunks +4 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/presentation-owned-elements.html View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/role-attribute.html View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
dmazzoni
4 years, 2 months ago (2016-09-29 22:39:26 UTC) #2
dmazzoni
4 years, 2 months ago (2016-09-29 22:40:40 UTC) #4
aboxhall
lgtm
4 years, 2 months ago (2016-09-30 20:13:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382083002/1
4 years, 2 months ago (2016-09-30 21:48:31 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 21:59:08 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 22:01:16 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/025c55dda400a5d2dd2ec435da38ec0d70a0d348
Cr-Commit-Position: refs/heads/master@{#422235}

Powered by Google App Engine
This is Rietveld 408576698