Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2382063002: Idle cleanup for worker context (Closed)

Created:
4 years, 2 months ago by ericrk
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Idle cleanup for worker context Currently, Skia flushes unused items out of its caches after ~1 second of non-use (50 flushes). This works fine while Skia is in-use, but when a worker context goes idle we stop calling into Skia altogether. This means that Skia will never flush out unused cache items from the last piece of work it did. This can lead to some rather large temporaries being kept around (~20mb). This change adds an idle cleanup process which flushes Skia's caches and cleans up worker context resources after a worker context is idle for 1 second. BUG=624630 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.blink:linux_precise_blink_dbg Committed: https://crrev.com/051ae83bf29b52cefd82235ebfb90f203912afbb Review-Url: https://codereview.chromium.org/2353033003 Cr-Original-Commit-Position: refs/heads/master@{#420496} Cr-Commit-Position: refs/heads/master@{#421092} (cherry picked from commit 6714c23b526197220d8b9abdbd38b6d9c206d912) Committed: https://chromium.googlesource.com/chromium/src/+/afec5ef67b207063bfbff5a5768b95b327393026

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -44 lines) Patch
M cc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M cc/output/context_cache_controller.h View 4 chunks +42 lines, -14 lines 0 comments Download
M cc/output/context_cache_controller.cc View 4 chunks +113 lines, -10 lines 0 comments Download
M cc/output/context_cache_controller_unittest.cc View 3 chunks +65 lines, -6 lines 0 comments Download
M cc/output/context_provider.h View 4 chunks +5 lines, -12 lines 0 comments Download
A cc/output/context_provider.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ericrk
4 years, 2 months ago (2016-09-29 22:23:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
afec5ef67b207063bfbff5a5768b95b327393026.

Powered by Google App Engine
This is Rietveld 408576698