Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2382053002: Remove unused option in server API (Closed)

Created:
4 years, 2 months ago by Brian Wilkerson
Modified:
4 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -866 lines) Patch
M pkg/analysis_server/doc/api.html View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 6 chunks +0 lines, -16 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 6 chunks +12 lines, -42 lines 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 2 chunks +2 lines, -10 lines 0 comments Download
D pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart View 1 chunk +0 lines, -260 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 4 chunks +3 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 3 chunks +2 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 8 chunks +0 lines, -17 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 3 chunks +0 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/domain_diagnostic_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/domain_execution_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/mocks.dart View 2 chunks +0 lines, -44 lines 0 comments Download
D pkg/analysis_server/test/source/caching_put_package_map_provider_test.dart View 1 chunk +0 lines, -404 lines 0 comments Download
D pkg/analysis_server/test/source/test_all.dart View 1 chunk +0 lines, -14 lines 0 comments Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/AnalysisServer.java View 1 chunk +14 lines, -13 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/source/pub_package_map_provider.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 2 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 2 months ago (2016-09-29 22:37:48 UTC) #2
scheglov
LGTM
4 years, 2 months ago (2016-09-29 23:33:39 UTC) #3
Brian Wilkerson
4 years, 2 months ago (2016-09-30 16:04:42 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2972bd0d6bdc9e208e9bcd775894a634c5a595ff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698