Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Issue 2382043003: Use ceil() when integerizing pagination struts before table rows. (Closed)
Patch Set: rebase master Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fragmentation/table-in-subpixel-fragmentainer-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
index e61330f627b20adb5573cbed021e4f94f03863f1..94d4263d1d2d338a29a17a9e2ea44cd9f0a5dbd5 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
@@ -1279,7 +1279,10 @@ int LayoutTableSection::paginationStrutForRow(LayoutTableRow* row,
// completely. No point in leaving a page completely blank.
return 0;
}
- return paginationStrut.toInt();
+ // Table layout parts only work on integers, so we have to round. Round up, to
+ // make sure that no fraction ever gets left behind in the previous
+ // fragmentainer.
+ return paginationStrut.ceil();
}
void LayoutTableSection::computeOverflowFromCells() {
« no previous file with comments | « third_party/WebKit/LayoutTests/fragmentation/table-in-subpixel-fragmentainer-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698