Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: src/objects-debug.cc

Issue 2382013002: [builtins] don't pre-flatten strings for JSStringIterator (Closed)
Patch Set: Also fix JSStringIteratorVerify() Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/builtins-string.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/objects.h" 5 #include "src/objects.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/disasm.h" 8 #include "src/disasm.h"
9 #include "src/disassembler.h" 9 #include "src/disassembler.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 767 matching lines...) Expand 10 before | Expand all | Expand 10 after
778 void JSWeakMap::JSWeakMapVerify() { 778 void JSWeakMap::JSWeakMapVerify() {
779 CHECK(IsJSWeakMap()); 779 CHECK(IsJSWeakMap());
780 JSObjectVerify(); 780 JSObjectVerify();
781 VerifyHeapPointer(table()); 781 VerifyHeapPointer(table());
782 CHECK(table()->IsHashTable() || table()->IsUndefined(GetIsolate())); 782 CHECK(table()->IsHashTable() || table()->IsUndefined(GetIsolate()));
783 } 783 }
784 784
785 void JSStringIterator::JSStringIteratorVerify() { 785 void JSStringIterator::JSStringIteratorVerify() {
786 CHECK(IsJSStringIterator()); 786 CHECK(IsJSStringIterator());
787 JSObjectVerify(); 787 JSObjectVerify();
788 CHECK(string()->IsSeqString() || string()->IsExternalString()); 788 CHECK(string()->IsString());
789 789
790 CHECK_GE(index(), 0); 790 CHECK_GE(index(), 0);
791 CHECK_LE(index(), String::kMaxLength); 791 CHECK_LE(index(), String::kMaxLength);
792 } 792 }
793 793
794 void JSWeakSet::JSWeakSetVerify() { 794 void JSWeakSet::JSWeakSetVerify() {
795 CHECK(IsJSWeakSet()); 795 CHECK(IsJSWeakSet());
796 JSObjectVerify(); 796 JSObjectVerify();
797 VerifyHeapPointer(table()); 797 VerifyHeapPointer(table());
798 CHECK(table()->IsHashTable() || table()->IsUndefined(GetIsolate())); 798 CHECK(table()->IsHashTable() || table()->IsUndefined(GetIsolate()));
(...skipping 563 matching lines...) Expand 10 before | Expand all | Expand 10 after
1362 1362
1363 // Both are done at the same time. 1363 // Both are done at the same time.
1364 CHECK_EQ(new_it.done(), old_it.done()); 1364 CHECK_EQ(new_it.done(), old_it.done());
1365 } 1365 }
1366 1366
1367 1367
1368 #endif // DEBUG 1368 #endif // DEBUG
1369 1369
1370 } // namespace internal 1370 } // namespace internal
1371 } // namespace v8 1371 } // namespace v8
OLDNEW
« no previous file with comments | « src/builtins/builtins-string.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698