Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2382013002: [builtins] don't pre-flatten strings for JSStringIterator (Closed)

Created:
4 years, 2 months ago by caitp
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] don't pre-flatten strings for JSStringIterator Seems to be pretty perf-neutral (for the benchmarks we have in the tree) against the pre-flattened version. BUG=v8:5388 R=bmeurer@chromium.org, adamk@chromium.org, littledan@chromium.org Committed: https://crrev.com/772ea9058827d11b7d947e04d98ea4cfb7b950d5 Cr-Commit-Position: refs/heads/master@{#39907}

Patch Set 1 #

Patch Set 2 : Remove more stuff #

Patch Set 3 : Also fix JSStringIteratorVerify() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -283 lines) Patch
M src/builtins/builtins-string.cc View 1 3 chunks +36 lines, -282 lines 0 comments Download
M src/objects-debug.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Benedikt Meurer
Nice simplification. Thanks. LGTM.
4 years, 2 months ago (2016-09-30 05:18:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382013002/40001
4 years, 2 months ago (2016-09-30 09:18:10 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-30 09:20:05 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 09:20:20 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/772ea9058827d11b7d947e04d98ea4cfb7b950d5
Cr-Commit-Position: refs/heads/master@{#39907}

Powered by Google App Engine
This is Rietveld 408576698