Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Issue 23820004: Don't listen for NOTIFICATION_TAB_CLOSING in TabModalConfirmDialogDelegate (Closed)

Created:
7 years, 3 months ago by Mike Wittman
Modified:
7 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Don't listen for NOTIFICATION_TAB_CLOSING in TabModalConfirmDialogDelegate WebContentsModalDialogManager closes web contents modal dialogs when the WebContents is destroyed, so there is no need for TabModalConfirmDialogDelegate to also close dialogs on tab closing. BUG=157161 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221219

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use DCHECK_EQ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc View 1 2 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike Wittman
7 years, 3 months ago (2013-09-03 23:56:25 UTC) #1
sky
LGTM https://codereview.chromium.org/23820004/diff/1/chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc File chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc (right): https://codereview.chromium.org/23820004/diff/1/chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc#newcode68 chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc:68: DCHECK(type == content::NOTIFICATION_LOAD_START); DCHECK_EQ
7 years, 3 months ago (2013-09-04 14:12:51 UTC) #2
Mike Wittman
https://codereview.chromium.org/23820004/diff/1/chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc File chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc (right): https://codereview.chromium.org/23820004/diff/1/chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc#newcode68 chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc:68: DCHECK(type == content::NOTIFICATION_LOAD_START); On 2013/09/04 14:12:51, sky wrote: > ...
7 years, 3 months ago (2013-09-04 16:59:28 UTC) #3
Mike Wittman
7 years, 3 months ago (2013-09-04 17:23:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r221219 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698