Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2381993002: Move fpdfsdk/fpdfxfa/include to fpdfsdk/fpdfxfa (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move fpdfsdk/fpdfxfa/include to fpdfsdk/fpdfxfa BUG=pdfium:611 Committed: https://pdfium.googlesource.com/pdfium/+/bec76925d40d28e6c26ca4bb456368ff5f69a607

Patch Set 1 #

Patch Set 2 : Rebase to master #

Patch Set 3 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -487 lines) Patch
M BUILD.gn View 1 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/cpdfsdk_annot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_annothandlermgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_baannothandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_environment.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_interform.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_pageview.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_widget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_widgethandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_xfawidgethandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_ext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfdoc_unittest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfeditpage.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfsave.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdftext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/fpdfxfa/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + fpdfsdk/fpdfxfa/fpdfxfa_app.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_app.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + fpdfsdk/fpdfxfa/fpdfxfa_doc.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + fpdfsdk/fpdfxfa/fpdfxfa_page.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_page.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + fpdfsdk/fpdfxfa/fpdfxfa_util.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_util.cpp View 1 chunk +1 line, -1 line 0 comments Download
D fpdfsdk/fpdfxfa/include/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D fpdfsdk/fpdfxfa/include/cpdfxfa_docenvironment.h View 1 chunk +0 lines, -112 lines 0 comments Download
D fpdfsdk/fpdfxfa/include/fpdfxfa_app.h View 1 chunk +0 lines, -79 lines 0 comments Download
D fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h View 1 chunk +0 lines, -95 lines 0 comments Download
D fpdfsdk/fpdfxfa/include/fpdfxfa_page.h View 1 chunk +0 lines, -85 lines 0 comments Download
D fpdfsdk/fpdfxfa/include/fpdfxfa_util.h View 1 chunk +0 lines, -48 lines 0 comments Download
M fpdfsdk/include/fsdk_define.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/cjs_runtime.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2377393002 Patch 40001

Dependent Patchsets:

Issue 2375963006 Patch 40001

Messages

Total messages: 14 (10 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-09-29 17:09:08 UTC) #2
Tom Sepez
lgtm
4 years, 2 months ago (2016-09-29 18:44:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381993002/40001
4 years, 2 months ago (2016-09-29 23:42:10 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 23:52:33 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/bec76925d40d28e6c26ca4bb456368ff5f69...

Powered by Google App Engine
This is Rietveld 408576698