Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2381963004: Reland "Letting Flash join MediaSession (stack implementaion)" (Closed)

Created:
4 years, 2 months ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Letting Flash join MediaSession (stack implementaion)" This CL lets Flash join and be managed by MediaSession. Flash will take "Gain" audio focus, and sessions with Flash will duck instead of being suspended. Test flags: --enable-default-media-session --ppapi-flash-path=/opt/google/chrome/PepperFlash/libpepflashplayer.so --enable-features=flash-join-media-session Test URL (can open multiple tabs and try): http://xxyzzzq.github.io/sandbox/media-session/flash-test.html BUG=619084 TBR=avayvod@chromium.org,jochen@chromium.org,mlamouri@chromium.org Committed: https://crrev.com/d36b5ce262564de9bf0fee7697a16e5a655472b4 Cr-Commit-Position: refs/heads/master@{#422142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+421 lines, -233 lines) Patch
M content/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/media/session/audio_focus_manager.h View 3 chunks +5 lines, -52 lines 0 comments Download
M content/browser/media/session/audio_focus_manager.cc View 2 chunks +55 lines, -77 lines 0 comments Download
M content/browser/media/session/audio_focus_manager_unittest.cc View 14 chunks +167 lines, -78 lines 0 comments Download
M content/browser/media/session/media_session.h View 5 chunks +26 lines, -11 lines 0 comments Download
M content/browser/media/session/media_session.cc View 14 chunks +66 lines, -14 lines 0 comments Download
M content/browser/media/session/media_session_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A docs/audio_focus.md View 1 chunk +98 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Zhiqiang Zhang (Slow)
The reason for the previous failure on the bots is actually: DCHECK(RequestSystemAudioFocus(AudioFocusManager::AudioFocusType::Gain)); which should be: ...
4 years, 2 months ago (2016-09-30 15:38:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381963004/1
4 years, 2 months ago (2016-09-30 15:38:40 UTC) #3
Zhiqiang Zhang (Slow)
On 2016/09/30 15:38:12, Zhiqiang Zhang wrote: > > It's sad that the try servers don't ...
4 years, 2 months ago (2016-09-30 15:42:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 17:29:59 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 17:33:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d36b5ce262564de9bf0fee7697a16e5a655472b4
Cr-Commit-Position: refs/heads/master@{#422142}

Powered by Google App Engine
This is Rietveld 408576698