Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2381963003: Revert of Small: Start checking URLs using PVer4. Verdict not returned to client yet. (Closed)

Created:
4 years, 2 months ago by vakh (use Gerrit instead)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, loading-reviews_chromium.org, grt+watch_chromium.org, Randy Smith (Not in Mondays), mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Small: Start checking URLs using PVer4. Verdict not returned to client yet. (patchset #9 id:180001 of https://codereview.chromium.org/2371043003/ ) Reason for revert: Reported by dfalcantara@ 09-30 14:35:21.701 27694 27767 E cr_SafeBrowsingApi: Failed to init handler: Attempt to invoke virtual method 'java.lang.Object java.lang.Class.newInstance()' on a null object reference 09-30 14:35:21.741 27694 27767 F chromium: [FATAL:ref_counted.h(322)] Assert failed: ptr_ != __null. Original issue's description: > Start checking URLs using PVer4. Verdict not returned to client yet. > > BUG=543161 > > Committed: https://crrev.com/17fb38d372c77f2dcbae3da61da22d20b0d98af9 > Cr-Commit-Position: refs/heads/master@{#421893} TBR=nparker@chromium.org,shess@chromium.org,mmenke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=543161 Committed: https://crrev.com/f627f9ad8d426baf9fc2fc4f56d88035baf80327 Cr-Commit-Position: refs/heads/master@{#421949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -163 lines) Patch
M chrome/browser/loader/safe_browsing_resource_throttle.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/loader/safe_browsing_resource_throttle.cc View 5 chunks +1 line, -16 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/services_delegate.h View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/services_delegate_impl.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/services_delegate_impl.cc View 5 chunks +26 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/services_delegate_stub.h View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/safe_browsing/services_delegate_stub.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M components/safe_browsing_db/BUILD.gn View 3 chunks +1 line, -11 lines 0 comments Download
D components/safe_browsing_db/v4_feature_list.h View 1 chunk +0 lines, -24 lines 0 comments Download
D components/safe_browsing_db/v4_feature_list.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager.h View 2 chunks +12 lines, -17 lines 0 comments Download
M components/safe_browsing_db/v4_local_database_manager.cc View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
vakh (use Gerrit instead)
Created Revert of Small: Start checking URLs using PVer4. Verdict not returned to client yet.
4 years, 2 months ago (2016-09-29 22:14:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381963003/1
4 years, 2 months ago (2016-09-29 22:15:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 22:16:39 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 22:18:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f627f9ad8d426baf9fc2fc4f56d88035baf80327
Cr-Commit-Position: refs/heads/master@{#421949}

Powered by Google App Engine
This is Rietveld 408576698