DevTools: Add test for SourceCodeDiff

DevTools: Add test for SourceCodeDiff

BUG=none

Committed: https://crrev.com/59102e2afaceec67dcab87bca2e5a2505f3202a3
Cr-Commit-Position: refs/heads/master@{#422283}

[einbinder, 2016-09-29 19:48:07]

einbinder@chromium.org changed reviewers:
+ lushnikov@chromium.org

[einbinder, 2016-09-29 19:48:08]

ptal

[lushnikov, 2016-09-29 21:10:33]

shell we add a bunch of these tests? You've spotted a few corner cases with
specific editions of first lines - should we cover those?

https://codereview.chromium.org/2381953004/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector/sources/resources/diff-after.css
(right):

https://codereview.chromium.org/2381953004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/sources/resources/diff-after.css:3:
width: 100%;
i failed to diff this against the other version manually. Imaging test start
failing - it would be hard to understand what's going on

Let's come up with something small and human-verifiable

https://codereview.chromium.org/2381953004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/sources/source-code-diff-expected.txt
(right):

https://codereview.chromium.org/2381953004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/sources/source-code-diff-expected.txt:3:
0:@
I initially thought that "@" is "not changed/context" until I opened the
diff-after.css.

Now i think it's "modified". Shell we use "modified/added/removed" to avoid
confusion?

[einbinder, 2016-09-29 22:33:18]

This test is going to get much more complicated and cover more edge cases once
you can revert changes.

https://codereview.chromium.org/2381953004/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector/sources/resources/diff-after.css
(right):

https://codereview.chromium.org/2381953004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/sources/resources/diff-after.css:3:
width: 100%;
On 2016/09/29 at 21:10:33, lushnikov wrote:
> i failed to diff this against the other version manually. Imaging test start
failing - it would be hard to understand what's going on
> 
> Let's come up with something small and human-verifiable

Done.

https://codereview.chromium.org/2381953004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/sources/source-code-diff-expected.txt
(right):

https://codereview.chromium.org/2381953004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/sources/source-code-diff-expected.txt:3:
0:@
On 2016/09/29 at 21:10:33, lushnikov wrote:
> I initially thought that "@" is "not changed/context" until I opened the
diff-after.css.
> 
> Now i think it's "modified". Shell we use "modified/added/removed" to avoid
confusion?

Done.

[lushnikov, 2016-09-30 16:29:45]

lgtm

It would be also nice to have a test that triggers that "merge" behavior you've
seen in the code

[einbinder, 2016-09-30 22:13:52]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2016-09-30 22:14:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 02:12:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-01 02:13:48]

Description was changed from

==========
DevTools: Add test for SourceCodeDiff

BUG=none
==========

to

==========
DevTools: Add test for SourceCodeDiff

BUG=none

Committed: https://crrev.com/59102e2afaceec67dcab87bca2e5a2505f3202a3
Cr-Commit-Position: refs/heads/master@{#422283}
==========

[commit-bot: I haz the power, 2016-10-01 02:13:49]

Patchset 2 (id:??) landed as
https://crrev.com/59102e2afaceec67dcab87bca2e5a2505f3202a3
Cr-Commit-Position: refs/heads/master@{#422283}