Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 2381913003: Support monitor profile in SampleApp (on Windows) (Closed)

Created:
4 years, 2 months ago by Brian Osman
Modified:
4 years, 2 months ago
Reviewers:
msarett, bsalomon, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Support monitor profile in SampleApp (on Windows) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2381913003 Committed: https://skia.googlesource.com/skia/+/35a02a83f5642de3afe88657c3fafd84b7b90735

Patch Set 1 #

Patch Set 2 : Fix Mac. Add a comment explaining insanity. #

Total comments: 1

Patch Set 3 : Spelling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -20 lines) Patch
M samplecode/SampleApp.h View 2 chunks +2 lines, -0 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 2 7 chunks +95 lines, -20 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Brian Osman
Sorry to be adding features to SampleApp. :) Also, this is really ugly. But... I ...
4 years, 2 months ago (2016-09-29 19:58:25 UTC) #5
msarett
lgtm https://codereview.chromium.org/2381913003/diff/20001/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): https://codereview.chromium.org/2381913003/diff/20001/samplecode/SampleApp.cpp#newcode325 samplecode/SampleApp.cpp:325: // in image in the gamut of the ...
4 years, 2 months ago (2016-09-29 21:05:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381913003/40001
4 years, 2 months ago (2016-09-29 21:20:28 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 21:37:05 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/35a02a83f5642de3afe88657c3fafd84b7b90735

Powered by Google App Engine
This is Rietveld 408576698