Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 23819067: Add new entry point that supports fallback font selection based on language. (Closed)

Created:
7 years, 3 months ago by djsollen
Modified:
7 years, 3 months ago
Reviewers:
Xianzhu, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add new entry point that supports fallback font selection based on language. BUG=chromium:287995 R=reed@google.com, wangxianzhu@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=11394

Patch Set 1 #

Total comments: 1

Patch Set 2 : improvements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -8 lines) Patch
M include/core/SkPaintOptionsAndroid.h View 1 1 chunk +1 line, -1 line 0 comments Download
M include/ports/SkTypeface_android.h View 1 1 chunk +23 lines, -1 line 0 comments Download
M src/ports/SkFontConfigInterface_android.cpp View 1 4 chunks +22 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
djsollen
7 years, 3 months ago (2013-09-17 15:15:32 UTC) #1
reed1
lgtm w/ parameter-style nit https://codereview.chromium.org/23819067/diff/1/include/ports/SkTypeface_android.h File include/ports/SkTypeface_android.h (right): https://codereview.chromium.org/23819067/diff/1/include/ports/SkTypeface_android.h#newcode39 include/ports/SkTypeface_android.h:39: SK_API bool SkGetFallbackFamilyNameForChar(SkUnichar uni, const ...
7 years, 3 months ago (2013-09-17 15:33:48 UTC) #2
Xianzhu
Thanks Derek for the fix! Actually I made a similar change yesterday and would upload ...
7 years, 3 months ago (2013-09-17 16:31:55 UTC) #3
Xianzhu
Just FYI, uploaded my patch https://codereview.chromium.org/23621052.
7 years, 3 months ago (2013-09-17 17:01:31 UTC) #4
djsollen
The font variant will always be elegant so there really isn't a need to set ...
7 years, 3 months ago (2013-09-17 17:14:17 UTC) #5
Xianzhu
lgtm
7 years, 3 months ago (2013-09-17 17:39:58 UTC) #6
djsollen
uploaded a new patch set that should address the comments.
7 years, 3 months ago (2013-09-17 18:45:06 UTC) #7
Xianzhu
lgtm. Derek, would you submit this CL soon?
7 years, 3 months ago (2013-09-19 16:44:37 UTC) #8
djsollen
7 years, 3 months ago (2013-09-19 18:22:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r11394 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698