Issue 23819066: Cleanup metrics in memreport.py.

Issue 23819066: Cleanup metrics in memreport.py. (Closed)

Created:
7 years, 3 months ago by Philippe

Modified:
7 years, 3 months ago

Reviewers:
bulach

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cleanup metrics in memreport.py. BUG=289130 R=bulach@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223343

Patch Set 2 : Address Marcus' comment #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	tools/android/memdump/memreport.py	View	1	1 chunk	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Philippe

Hi Marcus, This should hopefully make it slightly easier to read the reports :)

7 years, 3 months ago (2013-09-16 15:00:57 UTC) #1

bulach

lgtm, thanks! tiny suggestion below: https://codereview.chromium.org/23819066/diff/1/tools/android/memdump/memreport.py File tools/android/memdump/memreport.py (right): https://codereview.chromium.org/23819066/diff/1/tools/android/memdump/memreport.py#newcode39 tools/android/memdump/memreport.py:39: ('Native heap (tcmalloc)', '.* ...

7 years, 3 months ago (2013-09-16 15:12:06 UTC) #2

Philippe

Thanks Marcus! https://codereview.chromium.org/23819066/diff/1/tools/android/memdump/memreport.py File tools/android/memdump/memreport.py (right): https://codereview.chromium.org/23819066/diff/1/tools/android/memdump/memreport.py#newcode39 tools/android/memdump/memreport.py:39: ('Native heap (tcmalloc)', '.* r... .* \[anon:libc_malloc\]$'), ...

7 years, 3 months ago (2013-09-16 15:17:06 UTC) #3

Philippe

7 years, 3 months ago (2013-09-16 15:23:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r223343 (presubmit successful).

Expand Messages | Collapse Messages