Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 23819053: Rename usesOverlayScrollbars of settings to mockScrollbarsUseOverlay (Closed)

Created:
7 years, 3 months ago by Xianzhu
Modified:
7 years, 3 months ago
CC:
blink-reviews, jeez, dglazkov+blink, eae+blinkwatch, do-not-use
Visibility:
Public.

Description

Rename usesOverlayScrollbars of settings to mockScrollbarsUseOverlay usesOverlayScrollbars takes effect only if mockScrollbarsEnabled. Rename it to mockScrollbarsUseOverlay to avoid misuse. The existing misuse is that some tests call only window.internals.setUsesOverlayScrollbars(true) that will do nothing without window.interals.settings.setMockScrollbarsEnabled(true). Besides renaming, removed the original wrong placed window.internals.setUsesOverlayScrollbars() and added window.internals.settings.setMockScrollbarsUseOverlay(). Removed ScrollbarThemeMock::usesOverlayScrollbars() because ScrollbarThemeMock is not used when overlayScrollbars is enabled (ScroolbarThemeOverlayMock is used). Updated the tests that origially call setUsesOverlayScrollbar(true) only. BUG=none TEST=existing layout tests

Patch Set 1 #

Patch Set 2 : mockScrollbarsUses... -> mockScrollbarsUse... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -44 lines) Patch
M LayoutTests/fast/dom/partial-layout-block.html View 1 1 chunk +4 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/partial-layout-non-overlay-scrollbars.html View 1 1 chunk +5 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/partial-layout-overlay-scrollbars.html View 1 1 chunk +4 lines, -2 lines 0 comments Download
M LayoutTests/fast/scrolling/overlay-scrollbars.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/scrolling/scrollbar-tickmarks-hittest.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/page/Settings.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/Settings.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/platform/ScrollbarTheme.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/mock/ScrollbarThemeMock.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/mock/ScrollbarThemeMock.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/testing/InternalSettings.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/testing/InternalSettings.cpp View 1 3 chunks +8 lines, -0 lines 0 comments Download
M Source/core/testing/InternalSettings.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 9 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Xianzhu
7 years, 3 months ago (2013-09-11 23:21:00 UTC) #1
Xianzhu
7 years, 3 months ago (2013-09-11 23:21:54 UTC) #2
Xianzhu
ping...
7 years, 3 months ago (2013-09-12 22:54:42 UTC) #3
Xianzhu
On 2013/09/12 22:54:42, Xianzhu wrote: > ping... ping...
7 years, 3 months ago (2013-09-13 23:09:53 UTC) #4
Xianzhu
7 years, 3 months ago (2013-09-13 23:10:19 UTC) #5
ojan
lgtm
7 years, 3 months ago (2013-09-13 23:45:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/23819053/7001
7 years, 3 months ago (2013-09-13 23:45:46 UTC) #7
commit-bot: I haz the power
Failed to apply patch for LayoutTests/fast/dom/partial-layout-block.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 3 months ago (2013-09-13 23:45:54 UTC) #8
Xianzhu
Thanks ojan. I'll rebase and cq soon.
7 years, 3 months ago (2013-09-13 23:54:06 UTC) #9
Xianzhu
+tony who landed a similar change.
7 years, 3 months ago (2013-09-14 00:30:48 UTC) #10
Xianzhu
7 years, 3 months ago (2013-09-14 00:33:55 UTC) #11
Closing. Seems unnecessary after Tony's change. Thanks Tony for fixing the
issue.

Powered by Google App Engine
This is Rietveld 408576698