Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 23819041: Include Frame.h in fewer translation units. (Closed)

Created:
7 years, 3 months ago by Nico
Modified:
7 years, 3 months ago
Reviewers:
tony, dglazkov
CC:
blink-reviews, kenneth.christiansen, aboxhall, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, dglazkov+blink, dmazzoni, f(malita), jchaffraix+rendering, pdr, Stephen Chennney
Visibility:
Public.

Description

Include Frame.h in fewer translation units. Merges parts of Andreas Kling's http://trac.webkit.org/changeset/155217 "Out-of-line the three methods on FrameView that were operating on Frames. Most of the call sites were in FrameView.cpp so they will still get inlined." On my system, this reduces the number of build steps that run after touching Frame.h from 528 to 442 and reduces compilation time after touching Frame.h from 8.5 minutes to 7 minutes. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157458

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -14 lines) Patch
Source/core/accessibility/AccessibilityObject.cpp View 1 chunk +1 line, -0 lines 0 comments Download
Source/core/accessibility/AccessibilityRenderObject.cpp View 1 chunk +1 line, -0 lines 0 comments Download
Source/core/accessibility/AccessibilityScrollView.cpp View 1 chunk +1 line, -0 lines 0 comments Download
Source/core/page/FrameView.h View 4 chunks +4 lines, -14 lines 0 comments Download
Source/core/page/FrameView.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
Source/core/page/TouchAdjustment.cpp View 1 chunk +1 line, -0 lines 0 comments Download
Source/core/rendering/RenderLayerModelObject.cpp View 1 chunk +1 line, -0 lines 0 comments Download
Source/core/rendering/svg/RenderSVGResource.cpp View 1 chunk +1 line, -0 lines 0 comments Download
Source/core/rendering/svg/RenderSVGResourceClipper.cpp View 1 chunk +1 line, -0 lines 0 comments Download
Source/core/svg/graphics/SVGImage.cpp View 1 chunk +1 line, -0 lines 0 comments Download
Source/web/ExternalPopupMenu.cpp View 1 chunk +1 line, -0 lines 0 comments Download
Source/web/WebPagePopupImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
7 years, 3 months ago (2013-09-09 15:37:12 UTC) #1
Nico
(Oh, the side-by-side doesn't seem to work, but if you click "Raw" you'll see the ...
7 years, 3 months ago (2013-09-09 15:45:55 UTC) #2
dglazkov
lgtm.
7 years, 3 months ago (2013-09-09 16:31:06 UTC) #3
Nico
7 years, 3 months ago (2013-09-09 16:40:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r157458 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698