Create type masks lazily.

Create type masks lazily.

R=ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27379

[ngeoffray, 2013-09-09 12:37:46]

https://codereview.chromium.org/23819039/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/typechecker.dart (right):

https://codereview.chromium.org/23819039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/typechecker.dart:595: if
(elements.isTypeLiteral(node)) {
Thank you!

https://codereview.chromium.org/23819039/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart
(right):

https://codereview.chromium.org/23819039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart:680: T
visitTypeReferenceSend(Send node) {
Comments please, I don't understand this change.

https://codereview.chromium.org/23819039/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/types.dart (left):

https://codereview.chromium.org/23819039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/types.dart:184: //
TODO(ngeoffray): Get rid of this method. Unit tests don't always
Thank you :-)

https://codereview.chromium.org/23819039/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/types.dart (right):

https://codereview.chromium.org/23819039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/types.dart:73: dynamicTypeCache
= new TypeMask.subclass(compiler.objectClass.rawType);
Didn't you want to check if it's resolved? Maybe add a local ensureResolved
method that will check if it's resolved and throw in a later CL.

https://codereview.chromium.org/23819039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/types.dart:80: Backend backend =
compiler.backend;
Why this local? Same comment for all methods below.

https://codereview.chromium.org/23819039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/types.dart:310: nullType = new
TypeMask.empty();
The null class may also not be there, so maybe you should add a getter for it
too.

[Johnni Winther, 2013-09-10 13:19:35]

PTAL

https://codereview.chromium.org/23819039/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart
(right):

https://codereview.chromium.org/23819039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart:680: T
visitTypeReferenceSend(Send node) {
On 2013/09/09 12:37:46, ngeoffray wrote:
> Comments please, I don't understand this change.

Removed.

https://codereview.chromium.org/23819039/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/types.dart (right):

https://codereview.chromium.org/23819039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/types.dart:73: dynamicTypeCache
= new TypeMask.subclass(compiler.objectClass.rawType);
On 2013/09/09 12:37:46, ngeoffray wrote:
> Didn't you want to check if it's resolved? Maybe add a local ensureResolved
> method that will check if it's resolved and throw in a later CL.

Resolution is checked implicitly by the access to rawType.

https://codereview.chromium.org/23819039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/types.dart:80: Backend backend =
compiler.backend;
On 2013/09/09 12:37:46, ngeoffray wrote:
> Why this local? Same comment for all methods below.

All uses inlined.

https://codereview.chromium.org/23819039/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/types.dart:310: nullType = new
TypeMask.empty();
On 2013/09/09 12:37:46, ngeoffray wrote:
> The null class may also not be there, so maybe you should add a getter for it
> too.

Done.

[ngeoffray, 2013-09-11 10:27:05]

LGTM

https://codereview.chromium.org/23819039/diff/11001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart
(right):

https://codereview.chromium.org/23819039/diff/11001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart:683: }
Nit: use return ... ? ... : ...;

Also please add a comment on why this may not be a type literal.

[Johnni Winther, 2013-09-11 12:47:42]

https://codereview.chromium.org/23819039/diff/11001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart
(right):

https://codereview.chromium.org/23819039/diff/11001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart:683: }
On 2013/09/11 10:27:05, ngeoffray wrote:
> Nit: use return ... ? ... : ...;
> 
> Also please add a comment on why this may not be a type literal.

Done.

[Johnni Winther, 2013-09-11 12:52:09]

Committed patchset #4 manually as r27379 (presubmit successful).