Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/keyboard/resources/index.html

Issue 23819032: Dynamically load keyboard layouts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove console log. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/keyboard/resources/elements/kb-keyboard.html ('K') | « ui/keyboard/resources/elements/kb-keyboard.html ('k') | ui/keyboard/resources/layouts/dvorak.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/keyboard/resources/index.html
diff --git a/ui/keyboard/resources/index.html b/ui/keyboard/resources/index.html
index 3d237e55869a474c64d73e2891e0cd0f94313c4b..fafb09be4aae1b975dbe3476e5ab95b655379870 100644
--- a/ui/keyboard/resources/index.html
+++ b/ui/keyboard/resources/index.html
@@ -29,12 +29,12 @@
<link rel="import" href="elements/kb-keyboard.html">
<link rel="import" href="elements/kb-keyset.html">
<link rel="import" href="elements/kb-row.html">
- <!-- TODO(kevers|biao): Switch to dynamic loading strategy once supported
- in Polymer (http://www.crbug.com/260278).-->
- <link id="dvorak" rel="import" href="layouts/dvorak.html">
- <link id="numeric" rel="import" href="layouts/numeric.html">
- <link id="qwerty" rel="import" href="layouts/qwerty.html">
+ <link rel="import" href="elements/kb-key-sequence.html">
+ <link rel="import" href="elements/kb-key-import.html">
<!--TODO(stevet): Import 'Open Sans' font. -->
+ <!-- New layouts are dynamically loaded on demand. The link elements are
+ -- inserted here.
bshe 2013/09/06 21:12:21 If I understand correctly, it seems we can't load
kevers 2013/09/09 15:44:04 I believe the problem was that two of the elements
+ -->
</head>
<body>
<kb-keyboard id="keyboard" touch-action="none" layout="qwerty">
« ui/keyboard/resources/elements/kb-keyboard.html ('K') | « ui/keyboard/resources/elements/kb-keyboard.html ('k') | ui/keyboard/resources/layouts/dvorak.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698