Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 23819028: Close Views constrained web dialog on interstitial WebUI (Closed)

Created:
7 years, 3 months ago by Mike Wittman
Modified:
7 years, 3 months ago
Reviewers:
Lei Zhang, sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Close Views constrained web dialog on interstitial WebUI Configure Views constrained web dialogs to be closed when interstital WebUI is displayed (e.g. for SSL warnings prior to page load). Affects these dialogs: * print preview * SSL certificate viewer (Chrome OS only) * profile sign-in confirmation dialog BUG=240575 R=sky@chromium.org, thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221810

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike Wittman
Scott and Lei, PTAL. This builds on https://codereview.chromium.org/23981002. Lei: please review for the change in ...
7 years, 3 months ago (2013-09-05 21:22:59 UTC) #1
Lei Zhang
lgtm The existing behavior is definitely wrong for print preview.
7 years, 3 months ago (2013-09-05 21:39:08 UTC) #2
sky
LGTM
7 years, 3 months ago (2013-09-05 23:37:06 UTC) #3
Mike Wittman
7 years, 3 months ago (2013-09-06 23:16:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r221810 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698