Don't copy empty GUID in CopyIdentifyingProperties.

Don't copy empty GUID in CopyIdentifyingProperties.

This function copied an empty GUID leading to Shill not matching the right networks.
This change prevents copying an empty GUID and also checks that all other (required) identifying properties are non-empty.

BUG=280146
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221715

[stevenjb, 2013-09-05 17:00:40]

lgtm

https://codereview.chromium.org/23819024/diff/1/chromeos/network/shill_proper...
File chromeos/network/shill_property_util.cc (right):

https://codereview.chromium.org/23819024/diff/1/chromeos/network/shill_proper...
chromeos/network/shill_property_util.cc:233: LOG(ERROR) << "Missing required
identifying properties.";
Seems worth using NET_LOG_ERROR here?

[pneubeck (no reviews), 2013-09-06 12:53:33]

https://codereview.chromium.org/23819024/diff/1/chromeos/network/shill_proper...
File chromeos/network/shill_property_util.cc (right):

https://codereview.chromium.org/23819024/diff/1/chromeos/network/shill_proper...
chromeos/network/shill_property_util.cc:233: LOG(ERROR) << "Missing required
identifying properties.";
On 2013/09/05 17:00:41, stevenjb (chromium) wrote:
> Seems worth using NET_LOG_ERROR here?

Done.

[commit-bot: I haz the power, 2013-09-06 12:53:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pneubeck@chromium.org/23819024/7001

[commit-bot: I haz the power, 2013-09-06 16:22:29]

Change committed as 221715