chrome/common/extensions/extension.cc - Issue 23819020: Gives ChromeVox access to the web store again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension.cc

Issue 23819020: Gives ChromeVox access to the web store again. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Address comments. Use whitelist. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension.cc

diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc

index df10d27f93dfd53abfa0a659e8cbd112f4dae257..00d8834c2f8e6839fe3260ee0730879063999752 100644

--- a/chrome/common/extensions/extension.cc

+++ b/chrome/common/extensions/extension.cc

@@ -80,7 +80,7 @@ class ExtensionConfig {

// meant to be a general solution.

// TODO(dmazzoni): remove this once we have an extension API that

// allows any extension to request read-only access to webui pages.

- scripting_whitelist_.push_back("kgejglhpjiefppelpmljglcjbhoiplfn");

+ scripting_whitelist_.push_back(extension_misc::kChromeVoxExtensionId);

// Whitelist "Discover DevTools Companion" extension from Google that

// needs the ability to script DevTools pages. Companion will assist