Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: chrome/common/extensions/extension.cc

Issue 23819020: Gives ChromeVox access to the web store again. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Address comments. Use whitelist. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension.h" 5 #include "chrome/common/extensions/extension.h"
6 6
7 #include "base/base64.h" 7 #include "base/base64.h"
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 73
74 private: 74 private:
75 friend struct DefaultSingletonTraits<ExtensionConfig>; 75 friend struct DefaultSingletonTraits<ExtensionConfig>;
76 76
77 ExtensionConfig() { 77 ExtensionConfig() {
78 // Whitelist ChromeVox, an accessibility extension from Google that needs 78 // Whitelist ChromeVox, an accessibility extension from Google that needs
79 // the ability to script webui pages. This is temporary and is not 79 // the ability to script webui pages. This is temporary and is not
80 // meant to be a general solution. 80 // meant to be a general solution.
81 // TODO(dmazzoni): remove this once we have an extension API that 81 // TODO(dmazzoni): remove this once we have an extension API that
82 // allows any extension to request read-only access to webui pages. 82 // allows any extension to request read-only access to webui pages.
83 scripting_whitelist_.push_back("kgejglhpjiefppelpmljglcjbhoiplfn"); 83 scripting_whitelist_.push_back(extension_misc::kChromeVoxExtensionId);
84 84
85 // Whitelist "Discover DevTools Companion" extension from Google that 85 // Whitelist "Discover DevTools Companion" extension from Google that
86 // needs the ability to script DevTools pages. Companion will assist 86 // needs the ability to script DevTools pages. Companion will assist
87 // online courses and will be needed while the online educational programs 87 // online courses and will be needed while the online educational programs
88 // are in place. 88 // are in place.
89 scripting_whitelist_.push_back("angkfkebojeancgemegoedelbnjgcgme"); 89 scripting_whitelist_.push_back("angkfkebojeancgemegoedelbnjgcgme");
90 } 90 }
91 ~ExtensionConfig() { } 91 ~ExtensionConfig() { }
92 92
93 // A whitelist of extensions that can script anywhere. Do not add to this 93 // A whitelist of extensions that can script anywhere. Do not add to this
(...skipping 700 matching lines...) Expand 10 before | Expand all | Expand 10 after
794 794
795 UpdatedExtensionPermissionsInfo::UpdatedExtensionPermissionsInfo( 795 UpdatedExtensionPermissionsInfo::UpdatedExtensionPermissionsInfo(
796 const Extension* extension, 796 const Extension* extension,
797 const PermissionSet* permissions, 797 const PermissionSet* permissions,
798 Reason reason) 798 Reason reason)
799 : reason(reason), 799 : reason(reason),
800 extension(extension), 800 extension(extension),
801 permissions(permissions) {} 801 permissions(permissions) {}
802 802
803 } // namespace extensions 803 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | chrome/common/extensions/extension_constants.h » ('j') | chrome/common/extensions/extension_constants.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698