Gives ChromeVox access to the web store again.

Allow ChromeVox to have access to the web store again.

TEST=On aura, navigate to chrome.google.com/webstore; navigate through page and get spoken feedback.
BUG=285464
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221641

[dmazzoni, 2013-09-05 06:13:55]

+mpcomplete, who wrote renderer_permissions_policy_delegate.cc

https://codereview.chromium.org/23819020/diff/1/chrome/common/extensions/exte...
File chrome/common/extensions/extension_constants.cc (right):

https://codereview.chromium.org/23819020/diff/1/chrome/common/extensions/exte...
chrome/common/extensions/extension_constants.cc:129:
"mndnfokpggljbaajbnioimlmbfngpief";
We should move the constant currently found in extensions.cc to this file and
clearly distinguish between, e.g., kWebStoreChromeVoxExtensionId, and
kChromeOSChromeVoxExtensionId, or maybe kComponentChromeVoxExtensionId.

https://codereview.chromium.org/23819020/diff/1/chrome/renderer/extensions/re...
File chrome/renderer/extensions/renderer_permissions_policy_delegate.cc (right):

https://codereview.chromium.org/23819020/diff/1/chrome/renderer/extensions/re...
chrome/renderer/extensions/renderer_permissions_policy_delegate.cc:34: if
(extension->id() == extension_misc::kChromeVoxExtensionId)
Could we iterate over ExtensionConfig::get()->whitelist() instead?

[Matt Perry, 2013-09-05 18:54:28]

lgtm

https://codereview.chromium.org/23819020/diff/1/chrome/renderer/extensions/re...
File chrome/renderer/extensions/renderer_permissions_policy_delegate.cc (right):

https://codereview.chromium.org/23819020/diff/1/chrome/renderer/extensions/re...
chrome/renderer/extensions/renderer_permissions_policy_delegate.cc:34: if
(extension->id() == extension_misc::kChromeVoxExtensionId)
On 2013/09/05 06:13:55, Dominic Mazzoni wrote:
> Could we iterate over ExtensionConfig::get()->whitelist() instead?

Sounds reasonable.

[dmazzoni, 2013-09-05 19:02:58]

On Thu, Sep 5, 2013 at 11:54 AM, <mpcomplete@chromium.org> wrote:

> Could we iterate over ExtensionConfig::get()->**whitelist() instead?
>>
>
> Sounds reasonable.
>

Great. David, please add both ChromeVox extension ids to the whitelist and
then we can just allow all whitelisted extension ids here.

- Dominic

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2013-09-05 20:17:55]

PTAL; addressed all comments. Thanks.


On Thu, Sep 5, 2013 at 12:02 PM, Dominic Mazzoni <dmazzoni@chromium.org>wrote:

> On Thu, Sep 5, 2013 at 11:54 AM, <mpcomplete@chromium.org> wrote:
>
>> Could we iterate over ExtensionConfig::get()->**whitelist() instead?
>>>
>>
>> Sounds reasonable.
>>
>
> Great. David, please add both ChromeVox extension ids to the whitelist and
> then we can just allow all whitelisted extension ids here.
>
> - Dominic
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2013-09-05 20:35:22]

lgtm

https://codereview.chromium.org/23819020/diff/9001/chrome/common/extensions/e...
File chrome/common/extensions/extension_constants.cc (right):

https://codereview.chromium.org/23819020/diff/9001/chrome/common/extensions/e...
chrome/common/extensions/extension_constants.cc:128: const char
kChromeVoxExtensionId[] =
// Maybe add a comment here indicating this is the id of the build-in component
extension, and for the one below indicating it's the id of the extension on the
web store.

[David Tseng, 2013-09-05 20:43:42]

On Thu, Sep 5, 2013 at 1:35 PM, <dmazzoni@chromium.org> wrote:

> lgtm
>
>
>
>
> https://codereview.chromium.**org/23819020/diff/9001/chrome/**
>
common/extensions/extension_**constants.cc<https://codereview.chromium.org/23819020/diff/9001/chrome/common/extensions/extension_constants.cc>
> File chrome/common/extensions/**extension_constants.cc (right):
>
> https://codereview.chromium.**org/23819020/diff/9001/chrome/**
>
common/extensions/extension_**constants.cc#newcode128<https://codereview.chromium.org/23819020/diff/9001/chrome/common/extensions/extension_constants.cc#newcode128>
> chrome/common/extensions/**extension_constants.cc:128: const char
> kChromeVoxExtensionId[] =
> // Maybe add a comment here indicating this is the id of the build-in
> component extension, and for the one below indicating it's the id of the
> extension on the web store.
>
> Done.

>
https://codereview.chromium.**org/23819020/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-09-05 20:47:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtseng@chromium.org/23819020/14001

[commit-bot: I haz the power, 2013-09-05 20:58:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtseng@chromium.org/23819020/14001

[commit-bot: I haz the power, 2013-09-06 06:02:12]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2013-09-06 06:56:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtseng@chromium.org/23819020/14001

[commit-bot: I haz the power, 2013-09-06 08:11:39]

Change committed as 221641