Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 23819014: Hamfisted "fix" for pinterest blur crash (Closed)

Created:
7 years, 3 months ago by robertphillips
Modified:
7 years, 3 months ago
Reviewers:
humper, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

The Android perf tests are crashing (https://code.google.com/p/chromium/issues/detail?id=282418) when rendering pinterest on a Galaxy Nexus after r10936 (Blur refactoring - https://codereview.chromium.org/21835004/). I was not able to reproduce the exact crash they were seeing but did find one that may be the same one. In the bug I found, zooming out on the pinterest page eventually causes the filterRectMask/BlurRect code to yield a 2x1 smallR[0]. The downstream 9-patch code doesn't deal with this properly and accesses invalid memory. I tried fixing this by rounding out the destination in BlurRect (since the src rect was being rounded out the dest rect's round was causing the dest rect to be smaller then the src rect). That did "fix" the crash but negatively impacted the GM images. I'm not claiming this fix is right but it does stop the bleeding.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
robertphillips
7 years, 3 months ago (2013-08-31 15:30:10 UTC) #1
robertphillips
The reason this is happening is: Back in the old days only the radius was ...
7 years, 3 months ago (2013-09-03 14:33:04 UTC) #2
humper
On 2013/09/03 14:33:04, robertphillips wrote: > The reason this is happening is: > > Back ...
7 years, 3 months ago (2013-09-03 14:57:23 UTC) #3
robertphillips
7 years, 3 months ago (2013-09-03 17:17:56 UTC) #4
Message was sent while issue was closed.
committed as r11057

Powered by Google App Engine
This is Rietveld 408576698