Source/web/WebMediaPlayerClientImpl.cpp - Issue 23819007: Have Node::document() return a reference instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebMediaPlayerClientImpl.cpp

Issue 23819007: Have Node::document() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebMediaPlayerClientImpl.cpp

diff --git a/Source/web/WebMediaPlayerClientImpl.cpp b/Source/web/WebMediaPlayerClientImpl.cpp

index a4097f6bf805b046615ebf14853f6e3c3ad78c7a..a5e2c6eb24fcfba3b940158db991abebefa70b25 100644

--- a/Source/web/WebMediaPlayerClientImpl.cpp

+++ b/Source/web/WebMediaPlayerClientImpl.cpp

@@ -176,7 +176,7 @@ WebPlugin* WebMediaPlayerClientImpl::createHelperPlugin(const WebString& pluginT

// FIXME: Remove this override and cast when Chromium is updated to use closeHelperPluginSoon().

void WebMediaPlayerClientImpl::closeHelperPlugin()

{

- Frame* frame = static_cast<HTMLMediaElement*>(m_client)->document()->frame();

+ Frame* frame = static_cast<HTMLMediaElement*>(m_client)->document().frame();

WebFrameImpl* webFrame = WebFrameImpl::fromFrame(frame);

closeHelperPluginSoon(webFrame);

}

@@ -266,7 +266,7 @@ void WebMediaPlayerClientImpl::loadInternal()

#endif

// FIXME: Remove this cast

- Frame* frame = static_cast<HTMLMediaElement*>(m_client)->document()->frame();

+ Frame* frame = static_cast<HTMLMediaElement*>(m_client)->document().frame();

// This does not actually check whether the hardware can support accelerated

// compositing, but only if the flag is set. However, this is checked lazily

« no previous file with comments | « Source/web/WebElement.cpp ('k') | Source/web/WebNode.cpp » ('j') | no next file with comments »