Have Node::document() return a reference instead of a pointer

Source/web/WebPluginContainerImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 249 matching lines @@
 void WebPluginContainerImpl::setPlugin(WebPlugin* plugin)
 {
     if (plugin != m_webPlugin) {
         m_element->resetInstance();
         m_webPlugin = plugin;
     }
 }
 
 float WebPluginContainerImpl::deviceScaleFactor()
 {
-    Page* page = m_element->document()->page();
+    Page* page = m_element->document().page();
     if (!page)
         return 1.0;
     return page->deviceScaleFactor();
 }
 
 float WebPluginContainerImpl::pageScaleFactor()
 {
-    Page* page = m_element->document()->page();
+    Page* page = m_element->document().page();
     if (!page)
         return 1.0;
     return page->pageScaleFactor();
 }
 
 float WebPluginContainerImpl::pageZoomFactor()
 {
-    Frame* frame = m_element->document()->frame();
+    Frame* frame = m_element->document().frame();
     if (!frame)
         return 1.0;
     return frame->pageZoomFactor();
 }
 
 void WebPluginContainerImpl::setWebLayer(WebLayer* layer)
 {
     if (m_webLayer == layer)
         return;
 
@@ skipping 113 matching lines @@
         m_scrollbarGroup->setFrameRect(frameRect());
     }
 }
 
 void WebPluginContainerImpl::allowScriptObjects()
 {
 }
 
 void WebPluginContainerImpl::clearScriptObjects()
 {
-    Frame* frame = m_element->document()->frame();
+    Frame* frame = m_element->document().frame();
     if (!frame)
         return;
     frame->script()->cleanupScriptObjectsForPlugin(this);
 }
 
 NPObject* WebPluginContainerImpl::scriptableObjectForElement()
 {
     return m_element->getNPObject();
 }
 
 WebString WebPluginContainerImpl::executeScriptURL(const WebURL& url, bool popupsAllowed)
 {
-    Frame* frame = m_element->document()->frame();
+    Frame* frame = m_element->document().frame();
     if (!frame)
         return WebString();
 
     const KURL& kurl = url;
     ASSERT(kurl.protocolIs("javascript"));
 
     String script = decodeURLEscapeSequences(
         kurl.string().substring(strlen("javascript:")));
 
     ScriptValue result = frame->script()->executeScript(script, popupsAllowed);
 
     // Failure is reported as a null string.
     String resultStr;
     result.getString(resultStr);
     return resultStr;
 }
 
 void WebPluginContainerImpl::loadFrameRequest(const WebURLRequest& request, const WebString& target, bool notifyNeeded, void* notifyData)
 {
-    Frame* frame = m_element->document()->frame();
+    Frame* frame = m_element->document().frame();
     if (!frame || !frame->loader()->documentLoader())
         return;  // FIXME: send a notification in this case?
 
     if (notifyNeeded) {
         // FIXME: This is a bit of hack to allow us to observe completion of
         // our frame request.  It would be better to evolve FrameLoader to
         // support a completion callback instead.
         OwnPtr<WebPluginLoadObserver> observer = adoptPtr(new WebPluginLoadObserver(this, request.url(), notifyData));
         // FIXME: Calling get here is dangerous! What if observer is freed?
         m_pluginLoadObservers.append(observer.get());
         WebDataSourceImpl::setNextPluginLoadObserver(observer.release());
     }
 
     FrameLoadRequest frameRequest(frame->document()->securityOrigin(), request.toResourceRequest(), target);
     UserGestureIndicator gestureIndicator(request.hasUserGesture() ? DefinitelyProcessingNewUserGesture : PossiblyProcessingUserGesture);
     frame->loader()->load(frameRequest);
 }
 
 void WebPluginContainerImpl::zoomLevelChanged(double zoomLevel)
 {
-    WebViewImpl* view = WebViewImpl::fromPage(m_element->document()->frame()->page());
+    WebViewImpl* view = WebViewImpl::fromPage(m_element->document().frame()->page());
     view->fullFramePluginZoomLevelChanged(zoomLevel);
 }
 
 bool WebPluginContainerImpl::isRectTopmost(const WebRect& rect)
 {
-    Frame* frame = m_element->document()->frame();
+    Frame* frame = m_element->document().frame();
     if (!frame)
         return false;
 
     // hitTestResultAtPoint() takes a padding rectangle.
     // FIXME: We'll be off by 1 when the width or height is even.
     IntRect documentRect(x() + rect.x, y() + rect.y, rect.width, rect.height);
     LayoutPoint center = documentRect.center();
     // Make the rect we're checking (the point surrounded by padding rects) contained inside the requested rect. (Note that -1/2 is 0.)
     LayoutSize padding((documentRect.width() - 1) / 2, (documentRect.height() - 1) / 2);
     HitTestResult result = frame->eventHandler()->hitTestResultAtPoint(center, HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::DisallowShadowContent, padding);
     const HitTestResult::NodeSet& nodes = result.rectBasedTestResult();
     if (nodes.size() != 1)
         return false;
     return nodes.first().get() == m_element;
 }
 
 void WebPluginContainerImpl::requestTouchEventType(TouchEventRequestType requestType)
 {
     if (m_touchEventRequestType == requestType)
         return;
 
     if (requestType != TouchEventRequestTypeNone && m_touchEventRequestType == TouchEventRequestTypeNone)
-        m_element->document()->didAddTouchEventHandler(m_element);
+        m_element->document().didAddTouchEventHandler(m_element);
     else if (requestType == TouchEventRequestTypeNone && m_touchEventRequestType != TouchEventRequestTypeNone)
-        m_element->document()->didRemoveTouchEventHandler(m_element);
+        m_element->document().didRemoveTouchEventHandler(m_element);
     m_touchEventRequestType = requestType;
 }
 
 void WebPluginContainerImpl::setWantsWheelEvents(bool wantsWheelEvents)
 {
     if (m_wantsWheelEvents == wantsWheelEvents)
         return;
     m_wantsWheelEvents = wantsWheelEvents;
-    if (Page* page = m_element->document()->page()) {
+    if (Page* page = m_element->document().page()) {
         if (ScrollingCoordinator* scrollingCoordinator = page->scrollingCoordinator()) {
             if (parent() && parent()->isFrameView())
                 scrollingCoordinator->frameViewLayoutUpdated(toFrameView(parent()));
         }
     }
 }
 
 WebPoint WebPluginContainerImpl::windowToLocalPoint(const WebPoint& point)
 {
     ScrollView* view = parent();
@@ skipping 76 matching lines @@
 {
     size_t pos = m_pluginLoadObservers.find(observer);
     if (pos == notFound)
         return;
     m_pluginLoadObservers.remove(pos);
 }
 
 ScrollbarGroup* WebPluginContainerImpl::scrollbarGroup()
 {
     if (!m_scrollbarGroup)
-        m_scrollbarGroup = adoptPtr(new ScrollbarGroup(m_element->document()->frame()->view(), frameRect()));
+        m_scrollbarGroup = adoptPtr(new ScrollbarGroup(m_element->document().frame()->view(), frameRect()));
     return m_scrollbarGroup.get();
 }
 
 void WebPluginContainerImpl::willStartLiveResize()
 {
     if (m_scrollbarGroup)
         m_scrollbarGroup->willStartLiveResize();
 }
 
 void WebPluginContainerImpl::willEndLiveResize()
@@ skipping 19 matching lines @@
     , m_webPlugin(webPlugin)
     , m_webLayer(0)
     , m_touchEventRequestType(TouchEventRequestTypeNone)
     , m_wantsWheelEvents(false)
 {
 }
 
 WebPluginContainerImpl::~WebPluginContainerImpl()
 {
     if (m_touchEventRequestType != TouchEventRequestTypeNone)
-        m_element->document()->didRemoveTouchEventHandler(m_element);
+        m_element->document().didRemoveTouchEventHandler(m_element);
 
     for (size_t i = 0; i < m_pluginLoadObservers.size(); ++i)
         m_pluginLoadObservers[i]->clearPluginContainer();
     m_webPlugin->destroy();
     if (m_webLayer)
         GraphicsLayer::unregisterContentsLayer(m_webLayer);
 }
 
 void WebPluginContainerImpl::handleMouseEvent(MouseEvent* event)
 {
@@ skipping 106 matching lines @@
 
     // Copy stashed info over, and only copy here in order not to interfere
     // the ctrl-c logic above.
     if (currentInputEvent
         && WebInputEvent::isKeyboardEventType(currentInputEvent->type)) {
         webEvent.modifiers |= currentInputEvent->modifiers &
             (WebInputEvent::CapsLockOn | WebInputEvent::NumLockOn);
     }
 
     // Give the client a chance to issue edit comamnds.
-    WebViewImpl* view = WebViewImpl::fromPage(m_element->document()->frame()->page());
+    WebViewImpl* view = WebViewImpl::fromPage(m_element->document().frame()->page());
     if (m_webPlugin->supportsEditCommands() && view->client())
         view->client()->handleCurrentKeyboardEvent();
 
     WebCursorInfo cursorInfo;
     if (m_webPlugin->handleInputEvent(webEvent, cursorInfo))
         event->setDefaultHandled();
 }
 
 void WebPluginContainerImpl::handleTouchEvent(TouchEvent* event)
 {
@@ skipping 86 matching lines @@
     for (size_t i = 0; i < cutOutRects.size(); i++)
         cutOutRects[i].move(-frameRect.x(), -frameRect.y());
 }
 
 WebCore::IntRect WebPluginContainerImpl::windowClipRect() const
 {
     // Start by clipping to our bounds.
     IntRect clipRect =
         convertToContainingWindow(IntRect(0, 0, width(), height()));
 
-    // document()->renderer() can be 0 when we receive messages from the
+    // document().renderer() can be 0 when we receive messages from the
     // plugins while we are destroying a frame.
-    if (m_element->renderer()->document()->renderer()) {
+    if (m_element->renderer()->document().renderer()) {
         // Take our element and get the clip rect from the enclosing layer and
         // frame view.
         clipRect.intersect(
-            m_element->document()->view()->windowClipRectForFrameOwner(m_element, true));
+            m_element->document().view()->windowClipRectForFrameOwner(m_element, true));
     }
 
     return clipRect;
 }
 
 } // namespace WebKit