Have Node::document() return a reference instead of a pointer

Source/core/xml/parser/XMLDocumentParser.cpp

 /*
  * Copyright (C) 2000 Peter Kelly (pmk@post.com)
  * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2008 Holger Hans Peter Freyther
  * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 354 matching lines @@
     if (type != XMLErrors::warning)
         m_sawError = true;
     if (type == XMLErrors::fatal)
         stopParsing();
 }
 
 void XMLDocumentParser::enterText()
 {
     ASSERT(m_bufferedText.size() == 0);
     ASSERT(!m_leafTextNode);
-    m_leafTextNode = Text::create(m_currentNode->document(), "");
+    m_leafTextNode = Text::create(&m_currentNode->document(), "");
     m_currentNode->parserAppendChild(m_leafTextNode.get(), DeprecatedAttachNow);
 }
 
 void XMLDocumentParser::exitText()
 {
     if (isStopped())
         return;
 
     if (!m_leafTextNode)
         return;
@@ skipping 106 matching lines @@
 
 bool XMLDocumentParser::parseDocumentFragment(const String& chunk, DocumentFragment* fragment, Element* contextElement, ParserContentPolicy parserContentPolicy)
 {
     if (!chunk.length())
         return true;
 
     // FIXME: We need to implement the HTML5 XML Fragment parsing algorithm:
     // http://www.whatwg.org/specs/web-apps/current-work/multipage/the-xhtml-syntax.html#xml-fragment-parsing-algorithm
     // For now we have a hack for script/style innerHTML support:
     if (contextElement && (contextElement->hasLocalName(HTMLNames::scriptTag) || contextElement->hasLocalName(HTMLNames::styleTag))) {
-        fragment->parserAppendChild(fragment->document()->createTextNode(chunk));
+        fragment->parserAppendChild(fragment->document().createTextNode(chunk));
         return true;
     }
 
     RefPtr<XMLDocumentParser> parser = XMLDocumentParser::create(fragment, contextElement, parserContentPolicy);
     bool wellFormed = parser->appendFragmentSource(chunk);
     // Do not call finish().  Current finish() and doEnd() implementations touch the main Document/loader
     // and can cause crashes in the fragment case.
     parser->detach(); // Allows ~DocumentParser to assert it was detached before destruction.
     return wellFormed; // appendFragmentSource()'s wellFormed is more permissive than wellFormed().
 }
@@ skipping 258 matching lines @@
     , m_xmlErrors(document)
     , m_pendingScript(0)
     , m_scriptStartPosition(TextPosition::belowRangePosition())
     , m_parsingFragment(false)
 {
     // This is XML being used as a document resource.
     UseCounter::count(document, UseCounter::XMLDocument);
 }
 
 XMLDocumentParser::XMLDocumentParser(DocumentFragment* fragment, Element* parentElement, ParserContentPolicy parserContentPolicy)
-    : ScriptableDocumentParser(fragment->document(), parserContentPolicy)
+    : ScriptableDocumentParser(&fragment->document(), parserContentPolicy)
     , m_view(0)
     , m_context(0)
     , m_currentNode(fragment)
     , m_isCurrentlyParsing8BitChunk(false)
     , m_sawError(false)
     , m_sawCSS(false)
     , m_sawXSLTransform(false)
     , m_sawFirstElement(false)
     , m_isXHTMLDocument(false)
     , m_parserPaused(false)
     , m_requestingScript(false)
     , m_finishCalled(false)
-    , m_xmlErrors(fragment->document())
+    , m_xmlErrors(&fragment->document())
     , m_pendingScript(0)
     , m_scriptStartPosition(TextPosition::belowRangePosition())
     , m_parsingFragment(true)
 {
     fragment->ref();
 
     // Add namespaces based on the parent node
     Vector<Element*> elemStack;
     while (parentElement) {
         elemStack.append(parentElement);
@@ skipping 145 matching lines @@
         if (!prefix.isNull())
             adjustedURI = m_prefixToNamespaceMap.get(prefix);
         else
             adjustedURI = m_defaultNamespaceURI;
     }
 
     bool isFirstElement = !m_sawFirstElement;
     m_sawFirstElement = true;
 
     QualifiedName qName(prefix, localName, adjustedURI);
-    RefPtr<Element> newElement = m_currentNode->document()->createElement(qName, true);
+    RefPtr<Element> newElement = m_currentNode->document().createElement(qName, true);
     if (!newElement) {
         stopParsing();
         return;
     }
 
     Vector<Attribute> prefixedAttributes;
     TrackExceptionState es;
     handleNamespaceAttributes(prefixedAttributes, libxmlNamespaces, nbNamespaces, es);
     if (es.hadException()) {
         setAttributes(newElement.get(), prefixedAttributes, parserContentPolicy());
@@ skipping 155 matching lines @@
 
     if (m_parserPaused) {
         m_pendingCallbacks.append(adoptPtr(new PendingProcessingInstructionCallback(target ,data)));
         return;
     }
 
     exitText();
 
     // ### handle exceptions
     TrackExceptionState es;
-    RefPtr<ProcessingInstruction> pi = m_currentNode->document()->createProcessingInstruction(target, data, es);
+    RefPtr<ProcessingInstruction> pi = m_currentNode->document().createProcessingInstruction(target, data, es);
     if (es.hadException())
         return;
 
     pi->setCreatedByParser(true);
 
     m_currentNode->parserAppendChild(pi.get(), DeprecatedAttachNow);
 
     pi->finishParsingChildren();
 
     if (pi->isCSS())
         m_sawCSS = true;
     m_sawXSLTransform = !m_sawFirstElement && pi->isXSL();
     if (m_sawXSLTransform && !document()->transformSourceDocument())
         stopParsing();
 }
 
 void XMLDocumentParser::cdataBlock(const String& text)
 {
     if (isStopped())
         return;
 
     if (m_parserPaused) {
         m_pendingCallbacks.append(adoptPtr(new PendingCDATABlockCallback(text)));
         return;
     }
 
     exitText();
 
-    RefPtr<CDATASection> newNode = CDATASection::create(m_currentNode->document(), text);
+    RefPtr<CDATASection> newNode = CDATASection::create(&m_currentNode->document(), text);
     m_currentNode->parserAppendChild(newNode.get(), DeprecatedAttachNow);
 }
 
 void XMLDocumentParser::comment(const String& text)
 {
     if (isStopped())
         return;
 
     if (m_parserPaused) {
         m_pendingCallbacks.append(adoptPtr(new PendingCommentCallback(text)));
         return;
     }
 
     exitText();
 
-    RefPtr<Comment> newNode = Comment::create(m_currentNode->document(), text);
+    RefPtr<Comment> newNode = Comment::create(&m_currentNode->document(), text);
     m_currentNode->parserAppendChild(newNode.get(), DeprecatedAttachNow);
 }
 
 enum StandaloneInfo {
     StandaloneUnspecified = -2,
     NoXMlDeclaration,
     StandaloneNo,
     StandaloneYes
 };
 
@@ skipping 422 matching lines @@
     sax.initialized = XML_SAX2_MAGIC;
     RefPtr<XMLParserContext> parser = XMLParserContext::createStringParser(&sax, &state);
     String parseString = "<?xml version=\"1.0\"?><attrs " + string + " />";
     parseChunk(parser->context(), parseString);
     finishParsing(parser->context());
     attrsOK = state.gotAttributes;
     return state.attributes;
 }
 
 } // namespace WebCore