Have Node::document() return a reference instead of a pointer

Source/core/testing/Internals.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 794 matching lines @@
     return ClientRect::create(document->frame()->selection()->absoluteCaretBounds());
 }
 
 PassRefPtr<ClientRect> Internals::boundingBox(Element* element, ExceptionState& es)
 {
     if (!element) {
         es.throwDOMException(InvalidAccessError);
         return ClientRect::create();
     }
 
-    element->document()->updateLayoutIgnorePendingStylesheets();
+    element->document().updateLayoutIgnorePendingStylesheets();
     RenderObject* renderer = element->renderer();
     if (!renderer)
         return ClientRect::create();
     return ClientRect::create(renderer->absoluteBoundingBoxRectIgnoringTransforms());
 }
 
 PassRefPtr<ClientRectList> Internals::inspectorHighlightRects(Document* document, ExceptionState& es)
 {
     if (!document || !document->page()) {
         es.throwDOMException(InvalidAccessError);
@@ skipping 11 matching lines @@
         es.throwDOMException(InvalidAccessError);
         return 0;
     }
 
     DocumentMarker::MarkerTypes markerTypes = 0;
     if (!markerTypesFrom(markerType, markerTypes)) {
         es.throwDOMException(SyntaxError);
         return 0;
     }
 
-    return node->document()->markers()->markersFor(node, markerTypes).size();
+    return node->document().markers()->markersFor(node, markerTypes).size();
 }
 
 unsigned Internals::activeMarkerCountForNode(Node* node, ExceptionState& es)
 {
     if (!node) {
         es.throwDOMException(InvalidAccessError);
         return 0;
     }
 
     // Only TextMatch markers can be active.
     DocumentMarker::MarkerType markerType = DocumentMarker::TextMatch;
-    Vector<DocumentMarker*> markers = node->document()->markers()->markersFor(node, markerType);
+    Vector<DocumentMarker*> markers = node->document().markers()->markersFor(node, markerType);
 
     unsigned activeMarkerCount = 0;
     for (Vector<DocumentMarker*>::iterator iter = markers.begin(); iter != markers.end(); ++iter) {
         if ((*iter)->activeMatch())
             activeMarkerCount++;
     }
 
     return activeMarkerCount;
 }
 
 DocumentMarker* Internals::markerAt(Node* node, const String& markerType, unsigned index, ExceptionState& es)
 {
     if (!node) {
         es.throwDOMException(InvalidAccessError);
         return 0;
     }
 
     DocumentMarker::MarkerTypes markerTypes = 0;
     if (!markerTypesFrom(markerType, markerTypes)) {
         es.throwDOMException(SyntaxError);
         return 0;
     }
 
-    Vector<DocumentMarker*> markers = node->document()->markers()->markersFor(node, markerTypes);
+    Vector<DocumentMarker*> markers = node->document().markers()->markersFor(node, markerTypes);
     if (markers.size() <= index)
         return 0;
     return markers[index];
 }
 
 PassRefPtr<Range> Internals::markerRangeForNode(Node* node, const String& markerType, unsigned index, ExceptionState& es)
 {
     DocumentMarker* marker = markerAt(node, markerType, index, es);
     if (!marker)
         return 0;
-    return Range::create(node->document(), node, marker->startOffset(), node, marker->endOffset());
+    return Range::create(&node->document(), node, marker->startOffset(), node, marker->endOffset());
 }
 
 String Internals::markerDescriptionForNode(Node* node, const String& markerType, unsigned index, ExceptionState& es)
 {
     DocumentMarker* marker = markerAt(node, markerType, index, es);
     if (!marker)
         return String();
     return marker->description();
 }
 
 void Internals::addTextMatchMarker(const Range* range, bool isActive)
 {
     range->ownerDocument()->updateLayoutIgnorePendingStylesheets();
     range->ownerDocument()->markers()->addTextMatchMarker(range, isActive);
 }
 
 void Internals::setMarkersActive(Node* node, unsigned startOffset, unsigned endOffset, bool active, ExceptionState& es)
 {
     if (!node) {
         es.throwDOMException(InvalidAccessError);
         return;
     }
 
-    node->document()->markers()->setMarkersActive(node, startOffset, endOffset, active);
+    node->document().markers()->setMarkersActive(node, startOffset, endOffset, active);
 }
 
 void Internals::setScrollViewPosition(Document* document, long x, long y, ExceptionState& es)
 {
     if (!document || !document->view()) {
         es.throwDOMException(InvalidAccessError);
         return;
     }
 
     FrameView* frameView = document->view();
@@ skipping 154 matching lines @@
 {
     if (!element->hasTagName(inputTag)) {
         es.throwDOMException(InvalidAccessError);
         return;
     }
     toHTMLInputElement(element)->setAutofilled(enabled);
 }
 
 void Internals::scrollElementToRect(Element* element, long x, long y, long w, long h, ExceptionState& es)
 {
-    if (!element || !element->document() || !element->document()->view()) {
+    if (!element || !element->document().view()) {
         es.throwDOMException(InvalidAccessError);
         return;
     }
-    FrameView* frameView = element->document()->view();
+    FrameView* frameView = element->document().view();
     frameView->scrollElementToRect(element, IntRect(x, y, w, h));
 }
 
 void Internals::paintControlTints(Document* document, ExceptionState& es)
 {
     if (!document || !document->view()) {
         es.throwDOMException(InvalidAccessError);
         return;
     }
 
     FrameView* frameView = document->view();
     frameView->paintControlTints();
 }
 
 PassRefPtr<Range> Internals::rangeFromLocationAndLength(Element* scope, int rangeLocation, int rangeLength, ExceptionState& es)
 {
     if (!scope) {
         es.throwDOMException(InvalidAccessError);
         return 0;
     }
 
     // TextIterator depends on Layout information, make sure layout it up to date.
-    scope->document()->updateLayoutIgnorePendingStylesheets();
+    scope->document().updateLayoutIgnorePendingStylesheets();
 
     return TextIterator::rangeFromLocationAndLength(scope, rangeLocation, rangeLength);
 }
 
 unsigned Internals::locationFromRange(Element* scope, const Range* range, ExceptionState& es)
 {
     if (!scope || !range) {
         es.throwDOMException(InvalidAccessError);
         return 0;
     }
 
     // TextIterator depends on Layout information, make sure layout it up to date.
-    scope->document()->updateLayoutIgnorePendingStylesheets();
+    scope->document().updateLayoutIgnorePendingStylesheets();
 
     size_t location = 0;
     size_t unusedLength = 0;
     TextIterator::getLocationAndLengthFromRange(scope, range, location, unusedLength);
     return location;
 }
 
 unsigned Internals::lengthFromRange(Element* scope, const Range* range, ExceptionState& es)
 {
     if (!scope || !range) {
         es.throwDOMException(InvalidAccessError);
         return 0;
     }
 
     // TextIterator depends on Layout information, make sure layout it up to date.
-    scope->document()->updateLayoutIgnorePendingStylesheets();
+    scope->document().updateLayoutIgnorePendingStylesheets();
 
     size_t unusedLocation = 0;
     size_t length = 0;
     TextIterator::getLocationAndLengthFromRange(scope, range, unusedLocation, length);
     return length;
 }
 
 String Internals::rangeAsText(const Range* range, ExceptionState& es)
 {
     if (!range) {
@@ skipping 509 matching lines @@
     return elementLayerTreeAsText(element, 0, es);
 }
 
 static PassRefPtr<NodeList> paintOrderList(Element* element, ExceptionState& es, RenderLayer::PaintOrderListType type)
 {
     if (!element) {
         es.throwDOMException(InvalidAccessError);
         return 0;
     }
 
-    element->document()->updateLayout();
+    element->document().updateLayout();
 
     RenderObject* renderer = element->renderer();
     if (!renderer || !renderer->isBox()) {
         es.throwDOMException(InvalidAccessError);
         return 0;
     }
 
     RenderLayer* layer = toRenderBox(renderer)->layer();
     if (!layer) {
         es.throwDOMException(InvalidAccessError);
@@ skipping 15 matching lines @@
     return paintOrderList(element, es, RenderLayer::AfterPromote);
 }
 
 bool Internals::scrollsWithRespectTo(Element* element1, Element* element2, ExceptionState& es)
 {
     if (!element1 || !element2) {
         es.throwDOMException(InvalidAccessError);
         return 0;
     }
 
-    element1->document()->updateLayout();
+    element1->document().updateLayout();
 
     RenderObject* renderer1 = element1->renderer();
     RenderObject* renderer2 = element2->renderer();
     if (!renderer1 || !renderer2 || !renderer1->isBox() || !renderer2->isBox()) {
         es.throwDOMException(InvalidAccessError);
         return 0;
     }
 
     RenderLayer* layer1 = toRenderBox(renderer1)->layer();
     RenderLayer* layer2 = toRenderBox(renderer2)->layer();
@@ skipping 15 matching lines @@
     return document->frame()->layerTreeAsText(flags);
 }
 
 String Internals::elementLayerTreeAsText(Element* element, unsigned flags, ExceptionState& es) const
 {
     if (!element) {
         es.throwDOMException(InvalidAccessError);
         return String();
     }
 
-    element->document()->updateLayout();
+    element->document().updateLayout();
 
     RenderObject* renderer = element->renderer();
     if (!renderer || !renderer->isBox()) {
         es.throwDOMException(InvalidAccessError);
         return String();
     }
 
     RenderLayer* layer = toRenderBox(renderer)->layer();
     if (!layer
         || !layer->backing()
         || !layer->backing()->graphicsLayer()) {
         // Don't raise exception in these cases which may be normally used in tests.
         return String();
     }
 
     return layer->backing()->graphicsLayer()->layerTreeAsText(flags);
 }
 
 void Internals::setNeedsCompositedScrolling(Element* element, unsigned needsCompositedScrolling, ExceptionState& es)
 {
     if (!element) {
         es.throwDOMException(InvalidAccessError);
         return;
     }
 
-    element->document()->updateLayout();
+    element->document().updateLayout();
 
     RenderObject* renderer = element->renderer();
     if (!renderer || !renderer->isBox()) {
         es.throwDOMException(InvalidAccessError);
         return;
     }
 
     RenderLayer* layer = toRenderBox(renderer)->layer();
     if (!layer) {
         es.throwDOMException(InvalidAccessError);
@@ skipping 417 matching lines @@
         return false;
     sharedContext->getExtensions()->loseContextCHROMIUM(Extensions3D::GUILTY_CONTEXT_RESET_ARB, Extensions3D::INNOCENT_CONTEXT_RESET_ARB);
     // To prevent tests that call loseSharedGraphicsContext3D from being
     // flaky, we call finish so that the context is guaranteed to be lost
     // synchronously (i.e. before returning).
     sharedContext->finish();
     return true;
 }
 
 }