Have Node::document() return a reference instead of a pointer

Source/core/svg/SVGSVGElement.cpp

 /*
  * Copyright (C) 2004, 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Rob Buis <buis@kde.org>
  * Copyright (C) 2007 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 87 matching lines @@
 {
     return adoptRef(new SVGSVGElement(tagName, document));
 }
 
 SVGSVGElement::~SVGSVGElement()
 {
     if (m_viewSpec)
         m_viewSpec->resetContextElement();
     // There are cases where removedFromDocument() is not called.
     // see ContainerNode::removeAllChildren, called by its destructor.
-    document()->accessSVGExtensions()->removeTimeContainer(this);
+    document().accessSVGExtensions()->removeTimeContainer(this);
 }
 
 const AtomicString& SVGSVGElement::contentScriptType() const
 {
     DEFINE_STATIC_LOCAL(const AtomicString, defaultValue, ("text/ecmascript", AtomicString::ConstructFromLiteral));
     const AtomicString& n = fastGetAttribute(SVGNames::contentScriptTypeAttr);
     return n.isNull() ? defaultValue : n;
 }
 
 void SVGSVGElement::setContentScriptType(const AtomicString& type)
@@ skipping 47 matching lines @@
     if (!m_viewSpec)
         m_viewSpec = SVGViewSpec::create(this);
     return m_viewSpec.get();
 }
 
 float SVGSVGElement::currentScale() const
 {
     if (!inDocument() || !isOutermostSVGSVGElement())
         return 1;
 
-    Frame* frame = document()->frame();
+    Frame* frame = document().frame();
     if (!frame)
         return 1;
 
     FrameTree* frameTree = frame->tree();
     ASSERT(frameTree);
 
     // The behaviour of currentScale() is undefined, when we're dealing with non-standalone SVG documents.
     // If the svg is embedded, the scaling is handled by the host renderer, so when asking from inside
     // the SVG document, a scale value of 1 seems reasonable, as it doesn't know anything about the parent scale.
     return frameTree->parent() ? 1 : frame->pageZoomFactor();
 }
 
 void SVGSVGElement::setCurrentScale(float scale)
 {
     if (!inDocument() || !isOutermostSVGSVGElement())
         return;
 
-    Frame* frame = document()->frame();
+    Frame* frame = document().frame();
     if (!frame)
         return;
 
     FrameTree* frameTree = frame->tree();
     ASSERT(frameTree);
 
     // The behaviour of setCurrentScale() is undefined, when we're dealing with non-standalone SVG documents.
     // We choose the ignore this call, it's pretty useless to support calling setCurrentScale() from within
     // an embedded SVG document, for the same reasons as in currentScale() - needs resolution by SVG WG.
     if (frameTree->parent())
         return;
 
     frame->setPageZoomFactor(scale);
 }
 
 void SVGSVGElement::setCurrentTranslate(const FloatPoint& translation)
 {
     m_translation = translation;
     updateCurrentTranslate();
 }
 
 void SVGSVGElement::updateCurrentTranslate()
 {
     if (RenderObject* object = renderer())
         object->setNeedsLayout();
 
-    if (parentNode() == document() && document()->renderer())
-        document()->renderer()->repaint();
+    if (parentNode() == &document() && document().renderer())
+        document().renderer()->repaint();
 }
 
 void SVGSVGElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
 {
     SVGParsingError parseError = NoError;
 
     if (!nearestViewportElement()) {
         bool setListener = true;
 
         // Only handle events if we're the outermost <svg> element
         if (name == HTMLNames::onunloadAttr)
-            document()->setWindowAttributeEventListener(eventNames().unloadEvent, createAttributeEventListener(document()->frame(), name, value));
+            document().setWindowAttributeEventListener(eventNames().unloadEvent, createAttributeEventListener(document().frame(), name, value));
         else if (name == HTMLNames::onresizeAttr)
-            document()->setWindowAttributeEventListener(eventNames().resizeEvent, createAttributeEventListener(document()->frame(), name, value));
+            document().setWindowAttributeEventListener(eventNames().resizeEvent, createAttributeEventListener(document().frame(), name, value));
         else if (name == HTMLNames::onscrollAttr)
-            document()->setWindowAttributeEventListener(eventNames().scrollEvent, createAttributeEventListener(document()->frame(), name, value));
+            document().setWindowAttributeEventListener(eventNames().scrollEvent, createAttributeEventListener(document().frame(), name, value));
         else if (name == SVGNames::onzoomAttr)
-            document()->setWindowAttributeEventListener(eventNames().zoomEvent, createAttributeEventListener(document()->frame(), name, value));
+            document().setWindowAttributeEventListener(eventNames().zoomEvent, createAttributeEventListener(document().frame(), name, value));
         else
             setListener = false;
 
         if (setListener)
             return;
     }
 
     if (name == HTMLNames::onabortAttr)
-        document()->setWindowAttributeEventListener(eventNames().abortEvent, createAttributeEventListener(document()->frame(), name, value));
+        document().setWindowAttributeEventListener(eventNames().abortEvent, createAttributeEventListener(document().frame(), name, value));
     else if (name == HTMLNames::onerrorAttr)
-        document()->setWindowAttributeEventListener(eventNames().errorEvent, createAttributeEventListener(document()->frame(), name, value));
+        document().setWindowAttributeEventListener(eventNames().errorEvent, createAttributeEventListener(document().frame(), name, value));
     else if (name == SVGNames::xAttr)
         setXBaseValue(SVGLength::construct(LengthModeWidth, value, parseError));
     else if (name == SVGNames::yAttr)
         setYBaseValue(SVGLength::construct(LengthModeHeight, value, parseError));
     else if (name == SVGNames::widthAttr)
         setWidthBaseValue(SVGLength::construct(LengthModeWidth, value, parseError, ForbidNegativeLengths));
     else if (name == SVGNames::heightAttr)
         setHeightBaseValue(SVGLength::construct(LengthModeHeight, value, parseError, ForbidNegativeLengths));
     else if (SVGLangSpace::parseAttribute(name, value)
                || SVGExternalResourcesRequired::parseAttribute(name, value)
@@ skipping 106 matching lines @@
 
 bool SVGSVGElement::checkEnclosure(SVGElement* element, const SVGRect& rect) const
 {
     if (!element)
         return false;
     return RenderSVGModelObject::checkEnclosure(element->renderer(), rect);
 }
 
 void SVGSVGElement::deselectAll()
 {
-    if (Frame* frame = document()->frame())
+    if (Frame* frame = document().frame())
         frame->selection()->clear();
 }
 
 float SVGSVGElement::createSVGNumber()
 {
     return 0.0f;
 }
 
 SVGLength SVGSVGElement::createSVGLength()
 {
@@ skipping 59 matching lines @@
             // Translate in our CSS parent coordinate space
             // FIXME: This doesn't work correctly with CSS transforms.
             location = renderer->localToAbsolute(location, UseTransforms);
             location.scale(zoomFactor, zoomFactor);
 
             // Be careful here! localToBorderBoxTransform() included the x/y offset coming from the viewBoxToViewTransform(),
             // so we have to subtract it here (original cause of bug #27183)
             transform.translate(location.x() - viewBoxTransform.e(), location.y() - viewBoxTransform.f());
 
             // Respect scroll offset.
-            if (FrameView* view = document()->view()) {
+            if (FrameView* view = document().view()) {
                 LayoutSize scrollOffset = view->scrollOffset();
                 scrollOffset.scale(zoomFactor);
                 transform.translate(-scrollOffset.width(), -scrollOffset.height());
             }
         }
     }
 
     return transform.multiply(viewBoxTransform);
 }
 
 bool SVGSVGElement::rendererIsNeeded(const NodeRenderingContext& context)
 {
     // FIXME: We should respect display: none on the documentElement svg element
     // but many things in FrameView and SVGImage depend on the RenderSVGRoot when
     // they should instead depend on the RenderView.
     // https://bugs.webkit.org/show_bug.cgi?id=103493
-    if (document()->documentElement() == this)
+    if (document().documentElement() == this)
         return true;
     return Element::rendererIsNeeded(context);
 }
 
 RenderObject* SVGSVGElement::createRenderer(RenderStyle*)
 {
     if (isOutermostSVGSVGElement())
         return new RenderSVGRoot(this);
 
     return new RenderSVGViewportContainer(this);
 }
 
 Node::InsertionNotificationRequest SVGSVGElement::insertedInto(ContainerNode* rootParent)
 {
     if (rootParent->inDocument()) {
-        document()->accessSVGExtensions()->addTimeContainer(this);
+        document().accessSVGExtensions()->addTimeContainer(this);
 
         // Animations are started at the end of document parsing and after firing the load event,
         // but if we miss that train (deferred programmatic element insertion for example) we need
         // to initialize the time container here.
-        if (!document()->parsing() && !document()->processingLoadEvent() && document()->loadEventFinished() && !timeContainer()->isStarted())
+        if (!document().parsing() && !document().processingLoadEvent() && document().loadEventFinished() && !timeContainer()->isStarted())
             timeContainer()->begin();
     }
     return SVGGraphicsElement::insertedInto(rootParent);
 }
 
 void SVGSVGElement::removedFrom(ContainerNode* rootParent)
 {
     if (rootParent->inDocument())
-        document()->accessSVGExtensions()->removeTimeContainer(this);
+        document().accessSVGExtensions()->removeTimeContainer(this);
     SVGGraphicsElement::removedFrom(rootParent);
 }
 
 void SVGSVGElement::pauseAnimations()
 {
     if (!m_timeContainer->isPaused())
         m_timeContainer->pause();
 }
 
 void SVGSVGElement::unpauseAnimations()
@@ skipping 81 matching lines @@
     // - the SVG content is a separately stored resource that is embedded by reference (such as the ‘object’ element in XHTML [XHTML]), or
     //   the SVG content is embedded inline within a containing document;
     // - and the referencing element or containing document is styled using CSS [CSS2] or XSL [XSL];
     // - and there are CSS-compatible positioning properties ([CSS2], section 9.3) specified on the referencing element (e.g., the ‘object’ element)
     //   or on the containing document's outermost svg element that are sufficient to establish the width of the viewport. Under these conditions,
     //   the positioning properties establish the viewport's width.
     RenderSVGRoot* root = toRenderSVGRoot(renderer());
 
     // SVG embedded through object/embed/iframe.
     if (root->isEmbeddedThroughFrameContainingSVGDocument())
-        return !root->hasReplacedLogicalWidth() && !document()->frame()->ownerRenderer()->hasReplacedLogicalWidth();
+        return !root->hasReplacedLogicalWidth() && !document().frame()->ownerRenderer()->hasReplacedLogicalWidth();
 
     // SVG embedded via SVGImage (background-image/border-image/etc) / Inline SVG.
-    if (root->isEmbeddedThroughSVGImage() || document()->documentElement() != this)
+    if (root->isEmbeddedThroughSVGImage() || document().documentElement() != this)
         return !root->hasReplacedLogicalWidth();
 
     return true;
 }
 
 bool SVGSVGElement::heightAttributeEstablishesViewport() const
 {
     if (!renderer() || renderer()->isSVGViewportContainer())
         return true;
 
     // Spec: http://www.w3.org/TR/SVG/coords.html#IntrinsicSizing
     // Similarly, if there are positioning properties specified on the referencing element or on the outermost svg element
     // that are sufficient to establish the height of the viewport, then these positioning properties establish the viewport's
     // height; otherwise, the ‘height’ attribute on the outermost svg element establishes the viewport's height.
     RenderSVGRoot* root = toRenderSVGRoot(renderer());
 
     // SVG embedded through object/embed/iframe.
     if (root->isEmbeddedThroughFrameContainingSVGDocument())
-        return !root->hasReplacedLogicalHeight() && !document()->frame()->ownerRenderer()->hasReplacedLogicalHeight();
+        return !root->hasReplacedLogicalHeight() && !document().frame()->ownerRenderer()->hasReplacedLogicalHeight();
 
     // SVG embedded via SVGImage (background-image/border-image/etc) / Inline SVG.
-    if (root->isEmbeddedThroughSVGImage() || document()->documentElement() != this)
+    if (root->isEmbeddedThroughSVGImage() || document().documentElement() != this)
         return !root->hasReplacedLogicalHeight();
 
     return true;
 }
 
 Length SVGSVGElement::intrinsicWidth(ConsiderCSSMode mode) const
 {
     if (widthAttributeEstablishesViewport() || mode == IgnoreCSSProperties) {
         if (widthCurrentValue().unitType() == LengthTypePercentage)
             return Length(widthCurrentValue().valueAsPercentage() * 100, Percent);
@@ skipping 126 matching lines @@
             continue;
 
         Element* element = toElement(node);
         if (element->getIdAttribute() == id)
             return element;
     }
     return 0;
 }
 
 }