Have Node::document() return a reference instead of a pointer

Source/core/rendering/HitTestResult.cpp

 /*
  * Copyright (C) 2006, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Nokia Corporation and/or its subsidiary(-ies)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 94 matching lines @@
 
     // Only copy the NodeSet in case of rect hit test.
     m_rectBasedTestResult = adoptPtr(other.m_rectBasedTestResult ? new NodeSet(*other.m_rectBasedTestResult) : 0);
 
     return *this;
 }
 
 void HitTestResult::setToNodesInDocumentTreeScope()
 {
     if (Node* node = innerNode()) {
-        node = node->document()->ancestorInThisScope(node);
+        node = node->document().ancestorInThisScope(node);
         setInnerNode(node);
     }
 
     if (Node* node = innerNonSharedNode()) {
-        node = node->document()->ancestorInThisScope(node);
+        node = node->document().ancestorInThisScope(node);
         setInnerNonSharedNode(node);
     }
 }
 
 void HitTestResult::setToShadowHostIfInUserAgentShadowRoot()
 {
     if (Node* node = innerNode()) {
         if (ShadowRoot* containingShadowRoot = node->containingShadowRoot()) {
             if (containingShadowRoot->type() == ShadowRoot::UserAgentShadowRoot)
                 setInnerNode(node->shadowHost());
@@ skipping 28 matching lines @@
 }
 
 void HitTestResult::setScrollbar(Scrollbar* s)
 {
     m_scrollbar = s;
 }
 
 Frame* HitTestResult::innerNodeFrame() const
 {
     if (m_innerNonSharedNode)
-        return m_innerNonSharedNode->document()->frame();
+        return m_innerNonSharedNode->document().frame();
     if (m_innerNode)
-        return m_innerNode->document()->frame();
+        return m_innerNode->document().frame();
     return 0;
 }
 
 Frame* HitTestResult::targetFrame() const
 {
     if (!m_innerURLElement)
         return 0;
 
-    Frame* frame = m_innerURLElement->document()->frame();
+    Frame* frame = m_innerURLElement->document().frame();
     if (!frame)
         return 0;
 
     return frame->tree()->find(m_innerURLElement->target());
 }
 
 bool HitTestResult::isSelected() const
 {
     if (!m_innerNonSharedNode)
         return false;
 
-    Frame* frame = m_innerNonSharedNode->document()->frame();
+    Frame* frame = m_innerNonSharedNode->document().frame();
     if (!frame)
         return false;
 
     return frame->selection()->contains(m_hitTestLocation.point());
 }
 
 String HitTestResult::spellingToolTip(TextDirection& dir) const
 {
     dir = LTR;
     // Return the tool tip string associated with this point, if any. Only markers associated with bad grammar
     // currently supply strings, but maybe someday markers associated with misspelled words will also.
     if (!m_innerNonSharedNode)
         return String();
 
-    DocumentMarker* marker = m_innerNonSharedNode->document()->markers()->markerContainingPoint(m_hitTestLocation.point(), DocumentMarker::Grammar);
+    DocumentMarker* marker = m_innerNonSharedNode->document().markers()->markerContainingPoint(m_hitTestLocation.point(), DocumentMarker::Grammar);
     if (!marker)
         return String();
 
     if (RenderObject* renderer = m_innerNonSharedNode->renderer())
         dir = renderer->style()->direction();
     return marker->description();
 }
 
 String HitTestResult::title(TextDirection& dir) const
 {
@@ skipping 10 matching lines @@
             }
         }
     }
     return String();
 }
 
 String displayString(const String& string, const Node* node)
 {
     if (!node)
         return string;
-    return node->document()->displayStringModifiedByEncoding(string);
+    return node->document().displayStringModifiedByEncoding(string);
 }
 
 String HitTestResult::altDisplayString() const
 {
     if (!m_innerNonSharedNode)
         return String();
 
     if (m_innerNonSharedNode->hasTagName(imgTag)) {
         HTMLImageElement* image = toHTMLImageElement(m_innerNonSharedNode.get());
         return displayString(image->getAttribute(altAttr), m_innerNonSharedNode.get());
@@ skipping 24 matching lines @@
 
 IntRect HitTestResult::imageRect() const
 {
     if (!image())
         return IntRect();
     return m_innerNonSharedNode->renderBox()->absoluteContentQuad().enclosingBoundingBox();
 }
 
 KURL HitTestResult::absoluteImageURL() const
 {
-    if (!(m_innerNonSharedNode && m_innerNonSharedNode->document()))
+    if (!m_innerNonSharedNode)
         return KURL();
 
     if (!(m_innerNonSharedNode->renderer() && m_innerNonSharedNode->renderer()->isImage()))
         return KURL();
 
     AtomicString urlString;
     if (m_innerNonSharedNode->hasTagName(embedTag)
         || m_innerNonSharedNode->hasTagName(imgTag)
         || m_innerNonSharedNode->hasTagName(inputTag)
         || m_innerNonSharedNode->hasTagName(objectTag)
         || m_innerNonSharedNode->hasTagName(SVGNames::imageTag)
        ) {
         Element* element = toElement(m_innerNonSharedNode.get());
         urlString = element->imageSourceURL();
     } else
         return KURL();
 
-    return m_innerNonSharedNode->document()->completeURL(stripLeadingAndTrailingHTMLSpaces(urlString));
+    return m_innerNonSharedNode->document().completeURL(stripLeadingAndTrailingHTMLSpaces(urlString));
 }
 
 KURL HitTestResult::absoluteMediaURL() const
 {
     if (HTMLMediaElement* mediaElt = mediaElement())
         return mediaElt->currentSrc();
     return KURL();
 }
 
 HTMLMediaElement* HitTestResult::mediaElement() const
 {
-    if (!(m_innerNonSharedNode && m_innerNonSharedNode->document()))
+    if (!m_innerNonSharedNode)
         return 0;
 
     if (!(m_innerNonSharedNode->renderer() && m_innerNonSharedNode->renderer()->isMedia()))
         return 0;
 
     if (isHTMLVideoElement(m_innerNonSharedNode.get()) || m_innerNonSharedNode->hasTagName(HTMLNames::audioTag))
         return toHTMLMediaElement(m_innerNonSharedNode.get());
     return 0;
 }
 
 KURL HitTestResult::absoluteLinkURL() const
 {
-    if (!(m_innerURLElement && m_innerURLElement->document()))
+    if (!m_innerURLElement)
         return KURL();
 
     AtomicString urlString;
     if (isHTMLAnchorElement(m_innerURLElement.get()) || isHTMLAreaElement(m_innerURLElement.get()) || m_innerURLElement->hasTagName(linkTag))
         urlString = m_innerURLElement->getAttribute(hrefAttr);
     else if (m_innerURLElement->hasTagName(SVGNames::aTag))
         urlString = m_innerURLElement->getAttribute(XLinkNames::hrefAttr);
     else
         return KURL();
 
-    return m_innerURLElement->document()->completeURL(stripLeadingAndTrailingHTMLSpaces(urlString));
+    return m_innerURLElement->document().completeURL(stripLeadingAndTrailingHTMLSpaces(urlString));
 }
 
 bool HitTestResult::isLiveLink() const
 {
-    if (!(m_innerURLElement && m_innerURLElement->document()))
+    if (!m_innerURLElement)
         return false;
 
     if (isHTMLAnchorElement(m_innerURLElement.get()))
         return toHTMLAnchorElement(m_innerURLElement.get())->isLiveLink();
 
     if (m_innerURLElement->hasTagName(SVGNames::aTag))
         return m_innerURLElement->isLink();
 
     return false;
 }
 
 bool HitTestResult::isMisspelled() const
 {
     if (!targetNode())
         return false;
     VisiblePosition pos(targetNode()->renderer()->positionForPoint(localPoint()));
     if (pos.isNull())
         return false;
-    return m_innerNonSharedNode->document()->markers()->markersInRange(
+    return m_innerNonSharedNode->document().markers()->markersInRange(
         makeRange(pos, pos).get(), DocumentMarker::Spelling | DocumentMarker::Grammar).size() > 0;
 }
 
 String HitTestResult::titleDisplayString() const
 {
     if (!m_innerURLElement)
         return String();
 
     return displayString(m_innerURLElement->title(), m_innerURLElement.get());
 }
@@ skipping 28 matching lines @@
     // If it is not a rect-based hit test, this method has to be no-op.
     // Return false, so the hit test stops.
     if (!isRectBasedTest())
         return false;
 
     // If node is null, return true so the hit test can continue.
     if (!node)
         return true;
 
     if (request.disallowsShadowContent())
-        node = node->document()->ancestorInThisScope(node);
+        node = node->document().ancestorInThisScope(node);
 
     mutableRectBasedTestResult().add(node);
 
     bool regionFilled = rect.contains(locationInContainer.boundingBox());
     return !regionFilled;
 }
 
 bool HitTestResult::addNodeToRectBasedTestResult(Node* node, const HitTestRequest& request, const HitTestLocation& locationInContainer, const FloatRect& rect)
 {
     // If it is not a rect-based hit test, this method has to be no-op.
     // Return false, so the hit test stops.
     if (!isRectBasedTest())
         return false;
 
     // If node is null, return true so the hit test can continue.
     if (!node)
         return true;
 
     if (request.disallowsShadowContent())
-        node = node->document()->ancestorInThisScope(node);
+        node = node->document().ancestorInThisScope(node);
 
     mutableRectBasedTestResult().add(node);
 
     bool regionFilled = rect.contains(locationInContainer.boundingBox());
     return !regionFilled;
 }
 
 void HitTestResult::append(const HitTestResult& other)
 {
     ASSERT(isRectBasedTest() && other.isRectBasedTest());
@@ skipping 47 matching lines @@
 Element* HitTestResult::innerElement() const
 {
     for (Node* node = m_innerNode.get(); node; node = NodeRenderingTraversal::parent(node))
         if (node->isElementNode())
             return toElement(node);
 
     return 0;
 }
 
 } // namespace WebCore