Have Node::document() return a reference instead of a pointer

Source/core/html/HTMLElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2011 Motorola Mobility. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 56 matching lines @@
 PassRefPtr<HTMLElement> HTMLElement::create(const QualifiedName& tagName, Document* document)
 {
     return adoptRef(new HTMLElement(tagName, document));
 }
 
 String HTMLElement::nodeName() const
 {
     // FIXME: Would be nice to have an atomicstring lookup based off uppercase
     // chars that does not have to copy the string on a hit in the hash.
     // FIXME: We should have a way to detect XHTML elements and replace the hasPrefix() check with it.
-    if (document()->isHTMLDocument() && !tagQName().hasPrefix())
+    if (document().isHTMLDocument() && !tagQName().hasPrefix())
         return tagQName().localNameUpper();
     return Element::nodeName();
 }
 
 bool HTMLElement::ieForbidsInsertHTML() const
 {
     // FIXME: Supposedly IE disallows settting innerHTML, outerHTML
     // and createContextualFragment on these tags.  We have no tests to
     // verify this however, so this list could be totally wrong.
     // This list was moved from the previous endTagRequirement() implementation.
@@ skipping 200 matching lines @@
 
     if (name == dirAttr)
         dirAttributeChanged(value);
     else if (name == tabindexAttr) {
         int tabindex = 0;
         if (value.isEmpty()) {
             clearTabIndexExplicitlyIfNeeded();
             if (treeScope()->adjustedFocusedElement() == this) {
                 // We might want to call blur(), but it's dangerous to dispatch
                 // events here.
-                document()->setNeedsFocusedElementCheck();
+                document().setNeedsFocusedElementCheck();
             }
         } else if (parseHTMLInteger(value, tabindex)) {
             // Clamp tabindex to the range of 'short' to match Firefox's behavior.
             setTabIndexExplicitly(max(static_cast<int>(std::numeric_limits<short>::min()), min(tabindex, static_cast<int>(std::numeric_limits<short>::max()))));
         }
     } else {
         AtomicString eventName = eventNameForAttributeName(name);
         if (!eventName.isNull())
             setAttributeEventListener(eventName, createAttributeEventListener(this, name, value));
     }
@@ skipping 52 matching lines @@
     RefPtr<Node> node = next ? next->previousSibling() : 0;
     if (!es.hadException() && node && node->isTextNode())
         mergeWithNextTextNode(node.release(), es);
 
     if (!es.hadException() && prev && prev->isTextNode())
         mergeWithNextTextNode(prev.release(), es);
 }
 
 PassRefPtr<DocumentFragment> HTMLElement::textToFragment(const String& text, ExceptionState& es)
 {
-    RefPtr<DocumentFragment> fragment = DocumentFragment::create(document());
+    RefPtr<DocumentFragment> fragment = DocumentFragment::create(&document());
     unsigned int i, length = text.length();
     UChar c = 0;
     for (unsigned int start = 0; start < length; ) {
 
         // Find next line break.
         for (i = start; i < length; i++) {
           c = text[i];
           if (c == '\r' || c == '\n')
               break;
         }
 
-        fragment->appendChild(Text::create(document(), text.substring(start, i - start)), es);
+        fragment->appendChild(Text::create(&document(), text.substring(start, i - start)), es);
         if (es.hadException())
             return 0;
 
         if (c == '\r' || c == '\n') {
-            fragment->appendChild(HTMLBRElement::create(document()), es);
+            fragment->appendChild(HTMLBRElement::create(&document()), es);
             if (es.hadException())
                 return 0;
             // Make sure \r\n doesn't result in two line breaks.
             if (c == '\r' && i + 1 < length && text[i + 1] == '\n')
                 i++;
         }
 
         start = i + 1; // Character after line break.
     }
 
@@ skipping 68 matching lines @@
     }
 
     RefPtr<Node> prev = previousSibling();
     RefPtr<Node> next = nextSibling();
     RefPtr<Node> newChild;
 
     // Convert text to fragment with <br> tags instead of linebreaks if needed.
     if (text.contains('\r') || text.contains('\n'))
         newChild = textToFragment(text, es);
     else
-        newChild = Text::create(document(), text);
+        newChild = Text::create(&document(), text);
 
     if (!this || !parentNode())
         es.throwDOMException(HierarchyRequestError);
     if (es.hadException())
         return;
     parent->replaceChild(newChild.release(), this, es);
 
     RefPtr<Node> node = next ? next->previousSibling() : 0;
     if (!es.hadException() && node && node->isTextNode())
         mergeWithNextTextNode(node.release(), es);
@@ skipping 79 matching lines @@
     if (!contextElement)
         return;
     RefPtr<DocumentFragment> fragment = createFragmentForInnerOuterHTML(markup, contextElement, AllowScriptingContent, es);
     if (!fragment)
         return;
     insertAdjacent(where, fragment.get(), es);
 }
 
 void HTMLElement::insertAdjacentText(const String& where, const String& text, ExceptionState& es)
 {
-    RefPtr<Text> textNode = document()->createTextNode(text);
+    RefPtr<Text> textNode = document().createTextNode(text);
     insertAdjacent(where, textNode.get(), es);
 }
 
 void HTMLElement::applyAlignmentAttributeToStyle(const AtomicString& alignment, MutableStylePropertySet* style)
 {
     // Vertical alignment with respect to the current baseline of the text
     // right or left means floating images.
     CSSValueID floatValue = CSSValueInvalid;
     CSSValueID verticalAlignValue = CSSValueInvalid;
 
@@ skipping 31 matching lines @@
 }
 
 bool HTMLElement::supportsSpatialNavigationFocus() const
 {
     // This function checks whether the element satisfies the extended criteria
     // for the element to be focusable, introduced by spatial navigation feature,
     // i.e. checks if click or keyboard event handler is specified.
     // This is the way to make it possible to navigate to (focus) elements
     // which web designer meant for being active (made them respond to click events).
 
-    if (!document()->settings() || !document()->settings()->spatialNavigationEnabled())
+    if (!document().settings() || !document().settings()->spatialNavigationEnabled())
         return false;
     EventTarget* target = const_cast<HTMLElement*>(this);
     return target->hasEventListeners(eventNames().clickEvent)
         || target->hasEventListeners(eventNames().keydownEvent)
         || target->hasEventListeners(eventNames().keypressEvent)
         || target->hasEventListeners(eventNames().keyupEvent);
 }
 
 bool HTMLElement::supportsFocus() const
 {
@@ skipping 115 matching lines @@
 }
 
 void HTMLElement::setTranslate(bool enable)
 {
     setAttribute(translateAttr, enable ? "yes" : "no");
 }
 
 bool HTMLElement::rendererIsNeeded(const NodeRenderingContext& context)
 {
     if (hasLocalName(noscriptTag)) {
-        Frame* frame = document()->frame();
+        Frame* frame = document().frame();
         if (frame && frame->script()->canExecuteScripts(NotAboutToExecuteScript))
             return false;
     } else if (hasLocalName(noembedTag)) {
-        Frame* frame = document()->frame();
+        Frame* frame = document().frame();
         if (frame && frame->loader()->allowPlugins(NotAboutToInstantiatePlugin))
             return false;
     }
     return Element::rendererIsNeeded(context);
 }
 
 RenderObject* HTMLElement::createRenderer(RenderStyle* style)
 {
     if (hasLocalName(wbrTag))
         return new RenderWordBreak(this);
@@ skipping 142 matching lines @@
 {
     Node* strongDirectionalityTextNode;
     TextDirection textDirection = directionality(&strongDirectionalityTextNode);
     setHasDirAutoFlagRecursively(this, true, strongDirectionalityTextNode);
     if (renderer() && renderer()->style() && renderer()->style()->direction() != textDirection)
         setNeedsStyleRecalc();
 }
 
 void HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged(Node* beforeChange, int childCountDelta)
 {
-    if (document()->renderer() && childCountDelta < 0) {
+    if (document().renderer() && childCountDelta < 0) {
         Node* node = beforeChange ? NodeTraversal::nextSkippingChildren(beforeChange) : 0;
         for (int counter = 0; node && counter < childCountDelta; counter++, node = NodeTraversal::nextSkippingChildren(node)) {
             if (elementAffectsDirectionality(node))
                 continue;
 
             setHasDirAutoFlagRecursively(node, false);
         }
     }
 
     if (!selfOrAncestorHasDirAutoAttribute())
@@ skipping 130 matching lines @@
         handleKeypressEvent(toKeyboardEvent(event));
         if (event->defaultHandled())
             return;
     }
 
     Element::defaultEventHandler(event);
 }
 
 void HTMLElement::handleKeypressEvent(KeyboardEvent* event)
 {
-    if (!document()->settings() || !document()->settings()->spatialNavigationEnabled() || !supportsFocus())
+    if (!document().settings() || !document().settings()->spatialNavigationEnabled() || !supportsFocus())
         return;
     // if the element is a text form control (like <input type=text> or <textarea>)
     // or has contentEditable attribute on, we should enter a space or newline
     // even in spatial navigation mode instead of handling it as a "click" action.
     if (isTextFormControl() || isContentEditable())
         return;
     int charCode = event->charCode();
     if (charCode == '\r' || charCode == ' ') {
         dispatchSimulatedClick(event);
         event->setDefaultHandled();
     }
 }
 
 } // namespace WebCore
 
 #ifndef NDEBUG
 
 // For use in the debugger
 void dumpInnerHTML(WebCore::HTMLElement*);
 
 void dumpInnerHTML(WebCore::HTMLElement* element)
 {
     printf("%s\n", element->innerHTML().ascii().data());
 }
 #endif