Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2381893004: Remove caching from the draw-atlas GMs. Fixes bugs cycling backends. (Closed)

Created:
4 years, 2 months ago by Brian Osman
Modified:
4 years, 2 months ago
Reviewers:
mtklein_C, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove caching from the draw-atlas GMs. Fixes bugs cycling backends. When we would change backend or color type in SampleApp, we'd be rendering from a no-longer-valid image, leading to missing output, etc... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2381893004 Committed: https://skia.googlesource.com/skia/+/95e8d0a4ae3c755fd9ffbd0c276fc657999fecee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M gm/drawatlas.cpp View 3 chunks +3 lines, -7 lines 0 comments Download
M gm/drawatlascolor.cpp View 3 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Brian Osman
4 years, 2 months ago (2016-09-29 20:24:29 UTC) #3
mtklein_C
lgtm
4 years, 2 months ago (2016-09-29 20:26:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381893004/1
4 years, 2 months ago (2016-09-29 20:26:19 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 20:43:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/95e8d0a4ae3c755fd9ffbd0c276fc657999fecee

Powered by Google App Engine
This is Rietveld 408576698