Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 2381893003: Convert DCHECKs to CHECKs for histogram types (Closed)

Created:
2 years, 7 months ago by kenrb
Modified:
2 years, 7 months ago
Reviewers:
Ilya Sherman
CC:
asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert DCHECKs to CHECKs for histogram types When a histogram is looked up by name, there is currently a DCHECK that verifies the type of the stored histogram matches the expected type. A mismatch represents a significant problem because the returned HistogramBase is cast to a Histogram in ValidateRangeChecksum, potentially causing a crash. This CL converts the DCHECK to a CHECK to prevent the possibility of type confusion in release builds. BUG=651443 R=isherman@chromium.org Committed: https://crrev.com/03c2e97746a2c471ae136b0c669f8d0c033fe168 Cr-Commit-Position: refs/heads/master@{#421929}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/metrics/histogram.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/sparse_histogram.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
kenrb
Ilya: PTAL? I just cc'd you on the bug so you can see the context.
2 years, 7 months ago (2016-09-29 17:30:49 UTC) #1
Ilya Sherman
LGTM, thanks.
2 years, 7 months ago (2016-09-29 18:32:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381893003/1
2 years, 7 months ago (2016-09-29 18:34:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 7 months ago (2016-09-29 20:51:24 UTC) #7
commit-bot: I haz the power
2 years, 7 months ago (2016-09-29 20:55:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03c2e97746a2c471ae136b0c669f8d0c033fe168
Cr-Commit-Position: refs/heads/master@{#421929}

Powered by Google App Engine
This is Rietveld 408576698