Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2381783002: MD Settings: hide people section when signin is disabled (e.g. by policy) (Closed)

Created:
4 years, 2 months ago by Dan Beam
Modified:
4 years, 2 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: hide people section when signin is disabled (e.g. by policy) R=tommycli@chromium.org BUG=629604 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M chrome/browser/resources/settings/basic_page/basic_page.html View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/basic_page/basic_page.js View 1 chunk +3 lines, -0 lines 1 comment Download
M chrome/browser/resources/settings/people_page/people_page.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (6 generated)
tommycli
The code is lgtm. But only if we are indeed sure we want to hide ...
4 years, 2 months ago (2016-09-29 19:27:29 UTC) #6
Dan Beam
4 years, 2 months ago (2016-09-29 21:59:31 UTC) #8
Message was sent while issue was closed.
closing in favor of https://codereview.chromium.org/2375013004/

Powered by Google App Engine
This is Rietveld 408576698