Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: src/isolate.cc

Issue 2381773003: Add a flag for aborting on stack overflow. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/flag-definitions.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 9a21e236cff78bb6608250837e72e8ca49afbd24..435168fd0d058eef1a3eac993bc04ec74dbdb155 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -925,6 +925,10 @@ bool Isolate::MayAccess(Handle<Context> accessing_context,
Object* Isolate::StackOverflow() {
+ if (FLAG_abort_on_stack_overflow) {
+ V8_Fatal(__FILE__, __LINE__, "Aborting on stack overflow");
Michael Starzinger 2016/09/29 10:07:54 nit: Any reason not to use the "FATAL" macro inste
+ }
+
DisallowJavascriptExecution no_js(this);
HandleScope scope(this);
« no previous file with comments | « src/flag-definitions.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698