Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4642)

Unified Diff: ash/mus/system_tray_delegate_mus.h

Issue 2381753002: Use mojo SystemTray interfaces for both mash and classic ash (Closed)
Patch Set: Restructure based on feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/mus/system_tray_delegate_mus.h
diff --git a/ash/mus/system_tray_delegate_mus.h b/ash/mus/system_tray_delegate_mus.h
index e4dc6efe2b0ba7774890ca0e421affd23fb4f69d..49ba4070f43b7016b64d6459ef6d5bf145426e4d 100644
--- a/ash/mus/system_tray_delegate_mus.h
+++ b/ash/mus/system_tray_delegate_mus.h
@@ -21,61 +21,22 @@ namespace ash {
class NetworkingConfigDelegate;
class VPNDelegate;
-// Handles the settings displayed in the system tray menu. For mus most settings
-// are obtained from chrome browser via mojo IPC. For the classic ash version
-// see SystemTrayDelegateChromeOS.
+// Handles the settings displayed in the system tray menu. For the classic ash
+// version see SystemTrayDelegateChromeOS.
//
// Chrome OS only. Other platforms use DefaultSystemTrayDelegate directly.
//
// TODO: Support all methods in SystemTrayDelegate. http://crbug.com/647412.
-class SystemTrayDelegateMus : public DefaultSystemTrayDelegate,
- public mojom::SystemTray {
+class SystemTrayDelegateMus : public DefaultSystemTrayDelegate {
public:
- explicit SystemTrayDelegateMus(shell::Connector* connector);
+ SystemTrayDelegateMus();
~SystemTrayDelegateMus() override;
- static SystemTrayDelegateMus* Get();
-
private:
- // Connects or reconnects to the mojom::SystemTrayClient interface and returns
- // the interface pointer.
- mojom::SystemTrayClient* ConnectToSystemTrayClient();
-
- // Handles errors on the |system_tray_client_| interface connection.
- void OnClientConnectionError();
-
// SystemTrayDelegate:
- base::HourClockType GetHourClockType() const override;
- void ShowSettings() override;
- void ShowDateSettings() override;
- void ShowNetworkSettingsForGuid(const std::string& guid) override;
- void ShowDisplaySettings() override;
- void ShowPowerSettings() override;
- void ShowChromeSlow() override;
- void ShowIMESettings() override;
- void ShowHelp() override;
- void ShowAccessibilityHelp() override;
- void ShowAccessibilitySettings() override;
- void ShowPaletteHelp() override;
- void ShowPaletteSettings() override;
- void ShowPublicAccountInfo() override;
- void ShowEnterpriseInfo() override;
- void ShowProxySettings() override;
NetworkingConfigDelegate* GetNetworkingConfigDelegate() const override;
VPNDelegate* GetVPNDelegate() const override;
- // mojom::SystemTray:
- void SetUse24HourClock(bool use_24_hour) override;
-
- // May be null in unit tests.
- shell::Connector* connector_;
-
- // Client interface in chrome browser.
- mojom::SystemTrayClientPtr system_tray_client_;
-
- // 12 or 24 hour display.
- base::HourClockType hour_clock_type_;
-
std::unique_ptr<NetworkingConfigDelegate> networking_config_delegate_;
std::unique_ptr<VPNDelegate> vpn_delegate_;

Powered by Google App Engine
This is Rietveld 408576698