Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: tools/dom/scripts/systemnative.py

Issue 23817006: Dartium custom element lifecycle event support. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/scripts/systemnative.py
diff --git a/tools/dom/scripts/systemnative.py b/tools/dom/scripts/systemnative.py
index d36e0cd6b79e6a3ab0e805db66792421e55c15e0..9561264b56db421c0da14757c73a27f7de2b6265 100644
--- a/tools/dom/scripts/systemnative.py
+++ b/tools/dom/scripts/systemnative.py
@@ -709,6 +709,7 @@ class DartiumBackend(HtmlDartGenerator):
cpp_arguments = []
runtime_check = None
raises_exceptions = raises_dom_exception or arguments
+ needs_custom_element_callbacks = False
# TODO(antonm): unify with ScriptState below.
requires_stack_info = (ext_attrs.get('CallWith') == 'ScriptArguments|ScriptState' or
@@ -760,6 +761,10 @@ class DartiumBackend(HtmlDartGenerator):
if 'Reflect' in ext_attrs:
cpp_arguments = [self._GenerateWebCoreReflectionAttributeName(node)]
+ if ext_attrs.get('CustomElementCallbacks') == 'Enable':
+ self._cpp_impl_includes.add('"core/dom/CustomElementCallbackDispatcher.h"')
+ needs_custom_element_callbacks = True
+
if return_type_is_nullable:
cpp_arguments = ['isNull']
@@ -882,6 +887,9 @@ class DartiumBackend(HtmlDartGenerator):
' return;\n',
INDEX=len(arguments) + 1)
+ if needs_custom_element_callbacks:
+ body_emitter.Emit(' CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;\n');
+
# Emit arguments.
start_index = 1 if needs_receiver else 0
for i, argument in enumerate(arguments):

Powered by Google App Engine
This is Rietveld 408576698