Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2381663002: Revert of Update fieldtrial_util To Handle Combined Fieldtrial Config Format (Closed)

Created:
4 years, 2 months ago by robliao
Modified:
4 years, 2 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update fieldtrial_util To Handle Combined Fieldtrial Config Format (patchset #4 id:80001 of https://codereview.chromium.org/2373843002/ ) Reason for revert: Break in https://build.chromium.org/p/chromiumos.chromium/builders/amd64-generic-telemetry/builds/9845 This isn't part of the CQ run it appears. Original issue's description: > Update fieldtrial_util To Handle Combined Fieldtrial Config Format > > BUG=649363, 650705 > > Committed: https://crrev.com/1c70046ee9bfd7f0159b3408331e26b9f61ef49f > Cr-Commit-Position: refs/heads/master@{#421384} TBR=aiolos@chromium.org,asvitkine@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=649363, 650705 Committed: https://crrev.com/cf6e4a4caebe29f7f794bb5775d5d9f03e5e4dcb Cr-Commit-Position: refs/heads/master@{#421632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -126 lines) Patch
M tools/perf/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/perf/core/perf_benchmark.py View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/variations/fieldtrial_to_struct.py View 1 chunk +1 line, -5 lines 0 comments Download
M tools/variations/fieldtrial_util.py View 3 chunks +26 lines, -38 lines 0 comments Download
M tools/variations/fieldtrial_util_unittest.py View 3 chunks +34 lines, -77 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
robliao
Created Revert of Update fieldtrial_util To Handle Combined Fieldtrial Config Format
4 years, 2 months ago (2016-09-28 20:38:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381663002/1
4 years, 2 months ago (2016-09-28 20:38:45 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 20:39:41 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 20:42:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf6e4a4caebe29f7f794bb5775d5d9f03e5e4dcb
Cr-Commit-Position: refs/heads/master@{#421632}

Powered by Google App Engine
This is Rietveld 408576698