Fix uninit read in PlatformNotificationServiceTest

chrome/browser/notifications/platform_notification_service_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 
 #include <utility>
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
@@ skipping 59 matching lines @@
   void NotificationDisplayed() override { displayed_ = true; }
   void NotificationClosed() override {}
   void NotificationClick() override { clicked_ = true; }
 
   bool displayed() const { return displayed_; }
   bool clicked() const { return clicked_; }
 
  private:
   bool displayed_;
   bool clicked_;
+
+  DISALLOW_COPY_AND_ASSIGN(MockDesktopNotificationDelegate);
 };
 
 }  // namespace
 
 class PlatformNotificationServiceTest : public testing::Test {
  public:
   void SetUp() override {
-    profile_manager_.reset(
-        new TestingProfileManager(TestingBrowserProcess::GetGlobal()));
+    profile_manager_ = base::MakeUnique<TestingProfileManager>(
+        TestingBrowserProcess::GetGlobal());
     ASSERT_TRUE(profile_manager_->SetUp());
     profile_ = profile_manager_->CreateTestingProfile("Miguel");
-    std::unique_ptr<NotificationUIManager> ui_manager(
-        new StubNotificationUIManager);
-    std::unique_ptr<NotificationPlatformBridge> notification_bridge(
-        new StubNotificationPlatformBridge());
+    std::unique_ptr<NotificationUIManager> ui_manager =
+        base::MakeUnique<StubNotificationUIManager>();
+    std::unique_ptr<NotificationPlatformBridge> notification_bridge =
+        base::MakeUnique<StubNotificationPlatformBridge>();
 
     TestingBrowserProcess::GetGlobal()->SetNotificationUIManager(
         std::move(ui_manager));
     TestingBrowserProcess::GetGlobal()->SetNotificationPlatformBridge(
         std::move(notification_bridge));
   }
 
   void TearDown() override {
     profile_manager_.reset();
     TestingBrowserProcess::DeleteInstance();
@@ skipping 142 matching lines @@
   std::vector<int> vibration_pattern(
       kNotificationVibrationPattern,
       kNotificationVibrationPattern + arraysize(kNotificationVibrationPattern));
 
   PlatformNotificationData notification_data;
   notification_data.title = base::ASCIIToUTF16("My notification's title");
   notification_data.body = base::ASCIIToUTF16("Hello, world!");
   notification_data.vibration_pattern = vibration_pattern;
   notification_data.silent = true;
   notification_data.actions.resize(2);
+  notification_data.actions[0].type =

[awdf, 2016/09/29 10:47:57]

Am I correct in surmising that it was just the lack of these 4 lines caused the
warning you reported, the rest is just cleanup?

Thank you for fixing this. Sorry I didn't notice it myself - obviously I should
have looked for, run and fixed up the unit tests (if necessary) for every .cc
file changed - I will remember to do this in future! 

Out of interest, would the only way to have seen that warning been to run that
particular test locally? It's not visible on trybot results is it? (They were
all green ... except for android_n5x_swarming_rel  - what's that about?)

[awdf, 2016/09/29 13:06:34]

Peter's since explained that the test which gave the warning only runs
post-submit, and I couldn't have seen it by running the test locally. How did
you notice it then? - I would have expected an email from a post-submit step
saying my change could have been responsible, like for performance tests, but
didn't get one..

(Peter also suggested a more fundamental fix of making sure
PlatformNotificationAction's PlatformNotificationActionType has a default value
so is always initialized - I've now done that at
https://codereview.chromium.org/2381023002, you should be cc'd)

+      content::PLATFORM_NOTIFICATION_ACTION_TYPE_BUTTON;
   notification_data.actions[0].title = base::ASCIIToUTF16("Button 1");
+  notification_data.actions[1].type =
+      content::PLATFORM_NOTIFICATION_ACTION_TYPE_BUTTON;
   notification_data.actions[1].title = base::ASCIIToUTF16("Button 2");
 
   NotificationResources notification_resources;
   notification_resources.action_icons.resize(notification_data.actions.size());
 
   service()->DisplayPersistentNotification(
       profile(), kNotificationId, GURL() /* service_worker_scope */,
       GURL("https://chrome.com/"), notification_data, notification_resources);
 
   ASSERT_EQ(1u, GetNotificationCount());
@@ skipping 159 matching lines @@
       profile(),
       GURL() /* service_worker_scope */,
       GURL("chrome-extension://honijodknafkokifofgiaalefdiedpko/main.html"),
       notification_data, NotificationResources(),
       new MockNotificationDelegate("hello"));
   EXPECT_EQ("NotificationTest",
             base::UTF16ToUTF8(notification.context_message()));
 }
 
 #endif  // defined(ENABLE_EXTENSIONS)