Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 23816009: put js accessor ics behind a flags until fixed (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

put js accessor ics behind a flags until fixed R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16597

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M test/cctest/test-accessors.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
7 years, 3 months ago (2013-09-09 14:52:55 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/23816009/diff/1/test/cctest/test-accessors.cc File test/cctest/test-accessors.cc (right): https://codereview.chromium.org/23816009/diff/1/test/cctest/test-accessors.cc#newcode562 test/cctest/test-accessors.cc:562: v8::Function::New(isolate, handle_property); nit: Should fit into one line.
7 years, 3 months ago (2013-09-09 14:59:42 UTC) #2
dcarney
7 years, 3 months ago (2013-09-09 15:03:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16597 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698