Issue 23816009: put js accessor ics behind a flags until fixed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23816009: put js accessor ics behind a flags until fixed (Closed)

Created:
7 years, 3 months ago by dcarney

Modified:
7 years, 3 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

put js accessor ics behind a flags until fixed R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16597

Patch Set 2 : nit #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -3 lines)			Patch
M	src/flag-definitions.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ic.cc	View		3 chunks	+6 lines, -3 lines	0 comments	Download
M	test/cctest/test-accessors.cc	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/23816009/diff/1/test/cctest/test-accessors.cc File test/cctest/test-accessors.cc (right): https://codereview.chromium.org/23816009/diff/1/test/cctest/test-accessors.cc#newcode562 test/cctest/test-accessors.cc:562: v8::Function::New(isolate, handle_property); nit: Should fit into one line.

7 years, 3 months ago (2013-09-09 14:59:42 UTC) #2

dcarney

7 years, 3 months ago (2013-09-09 15:03:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r16597 (presubmit successful).

Expand Messages | Collapse Messages

Issue 23816009: put js accessor ics behind a flags until fixed (Closed)

Description

Patch Set 1 #

Patch Set 2 : nit #

Messages