Issue 23816002: drive: Stop using resource ID to access local metadata in OpenFileOperation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23816002: drive: Stop using resource ID to access local metadata in OpenFileOperation (Closed)

Created:
7 years, 3 months ago by hashimoto

Modified:
7 years, 2 months ago

Reviewers:
kinaba

CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik+watch_chromium.org, oshima+watch_chromium.org, tfarina, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Stop using resource ID to access local metadata in OpenFileOperation BUG=275270 TEST=unit_tests R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225314

Patch Set 1 : #

Patch Set 2 : new #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -24 lines)			Patch
M	chrome/browser/chromeos/drive/file_system/open_file_operation.h	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/open_file_operation.cc	View	1	2 chunks	+10 lines, -10 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/open_file_operation_unittest.cc	View	1	5 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

7 years, 3 months ago (2013-09-10 10:39:41 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/23816002/13001

7 years, 2 months ago (2013-09-26 02:18:05 UTC) #5

hashimoto

7 years, 2 months ago (2013-09-26 04:06:30 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r225314 (presubmit successful).

Expand Messages | Collapse Messages